Enhancement/network proxy single action - #1903
Open
Douglasymlai wants to merge 2 commits into
Open
Conversation
Replaces the separate Save and Reset buttons with a single action nested inside the input field. It reads "Save" while the field differs from the persisted baseline and "Reset" once they match, where Reset clears the saved HTTP_PROXY. - Compare untrimmed so a whitespace-only edit still reads "Save". The destructive Reset must never sit under a field the user just typed in. - Disable the action when there is no saved proxy left to clear. - Move the restart affordance off the button into the success toast, as a sonner action, echoed by a DsText meta footnote in the error tone so a pending restart stays visible after the toast is gone. - Reserve right padding on the field so a long proxy URL does not slide under the nested button. - Add proxy-cleared-restart-required and proxy-reset-failed across all 11 locales. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
Followup PR for #1893
Description
Testing Evidence (REQUIRED)
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement