-
Notifications
You must be signed in to change notification settings - Fork 32
Add tests which are verifying comp_req__launch_man__launcher_exit_shutdown #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TimoSteuerwaldETAS
wants to merge
25
commits into
eclipse-score:main
Choose a base branch
from
etas-contrib:feature/shutdown_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,368
−13
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
5891c5c
Mainly cherry picked commits from internal branch
TimoSteuerwaldETAS d555b8c
Add crashdump support in docker environment
TimoSteuerwaldETAS df7fc18
Log PID
TimoSteuerwaldETAS f47e90a
Proposed fix by Claude.
TimoSteuerwaldETAS 26d29db
Increase shutdown_timeout
TimoSteuerwaldETAS d01df84
Revert FAIL
TimoSteuerwaldETAS b077c92
Honor the termination timeout during shutdown
TimoSteuerwaldETAS d47eec1
Add method to TestRunner
TimoSteuerwaldETAS 6dfa775
Only check shutdown timeout of currently active runtarget
TimoSteuerwaldETAS f46a63b
Consider only the shutdown timeout of active processes
TimoSteuerwaldETAS 2a031a2
Format fix
TimoSteuerwaldETAS 8f7f8d6
Reconstruct file paths automatically
TimoSteuerwaldETAS f6fc174
Align to naming schema on main branch
TimoSteuerwaldETAS bb808b1
Update requirement name
TimoSteuerwaldETAS 7e17a17
Change log level
TimoSteuerwaldETAS b59b010
Shrink comments & tiny adaptions
TimoSteuerwaldETAS a4fff21
Refactor code to simply use run_until_file_deployed(..)
TimoSteuerwaldETAS e363ada
Get rid of identical component_a.cpp files.
TimoSteuerwaldETAS 4b8f851
Update comment regarding deinit order
TimoSteuerwaldETAS e5e7c74
Move control client mocks -> test driver
TimoSteuerwaldETAS 4958a85
Update references to control_client_test_driver
TimoSteuerwaldETAS bc1085d
Get rid of waitForTermination()
TimoSteuerwaldETAS 26b29e5
Shrink comments
TimoSteuerwaldETAS e69d0ef
Add bazel option --config=core_dump
TimoSteuerwaldETAS 673e52e
Execute gdb in docker
TimoSteuerwaldETAS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| load("@rules_cc//cc:cc_binary.bzl", "cc_binary") | ||
| load("@rules_cc//cc:cc_library.bzl", "cc_library") | ||
| load("//tests/utils/bazel:integration.bzl", "integration_test") | ||
|
|
||
| cc_library( | ||
| name = "lm_shutdown_common", | ||
| hdrs = ["common.hpp"], | ||
| ) | ||
|
|
||
| cc_binary( | ||
| name = "control_client_test_driver", | ||
| srcs = ["control_client_test_driver.cpp"], | ||
| deps = [ | ||
| ":lm_shutdown_common", | ||
| "//score/launch_manager:control_cc", | ||
| "//score/launch_manager:lifecycle_cc", | ||
| "//tests/utils/test_helper", | ||
| "@googletest//:gtest_main", | ||
| ], | ||
| ) | ||
|
|
||
| cc_binary( | ||
| name = "component_c", | ||
| srcs = ["component_c.cpp"], | ||
| deps = [ | ||
| ":lm_shutdown_common", | ||
| "//score/launch_manager:lifecycle_cc", | ||
| "//tests/utils/test_helper", | ||
| "@googletest//:gtest_main", | ||
| ], | ||
| ) | ||
|
|
||
| integration_test( | ||
| name = "lm_shutdown_during_rt_switch", | ||
| timeout = "short", | ||
| srcs = ["lm_shutdown_during_rt_switch.py"], | ||
| binaries = [ | ||
| "//tests/utils/test_helper:process_hanging_on_sigterm", | ||
| ":component_c", | ||
| ":control_client_test_driver", | ||
| "//score/launch_manager", | ||
| ], | ||
| config = ":lm_shutdown_during_rt_switch.json", | ||
| ) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it shows up my suggested change but I think the @details section should be removed