Add tests which are verifying comp_req__launch_man__launcher_exit_shutdown by TimoSteuerwaldETAS · Pull Request #450 · eclipse-score/lifecycle

TimoSteuerwaldETAS · 2026-08-11T11:03:20Z

Part of #317

comp_req__launch_man__launcher_exit_shutdown
The Launch Manager shall exit after performing shutdown operation by
stopping all the Processes <Process> it owns in the dependency order when requested.

github-actions · 2026-08-11T11:04:58Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 22105320-95be-4341-a230-fb232604f0d6
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (34 packages loaded, 10 targets configured)

Analyzing: target //:license-check (87 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (152 packages loaded, 3161 targets configured)

Analyzing: target //:license-check (162 packages loaded, 6895 targets configured)

Analyzing: target //:license-check (167 packages loaded, 9402 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9451 targets configured)

Analyzing: target //:license-check (173 packages loaded, 9575 targets configured)

INFO: Analyzed target //:license-check (177 packages loaded, 11589 targets configured).
[14 / 16] [Prepa] Generating Dash formatted dependency file ... ... (2 actions, 0 running)
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.299s, Critical Path: 0.28s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-08-13T08:26:43Z

The created documentation from the pull request is available at: docu-html

These commits have been squashed together to ease review. After cherry pick some conflicts have been solved wrong, this is why there are two additional commits also. For details please also have a look onto the internal branch in etas-eng feature/create-process-launch-fit-specification-unverified The original commit message of this commit: Add a log message for SIGTERM receival Move dir tests/integration/lm_shutdown to tests/integration/lm_shutdown_during_rt_switch Update references accordingly Add lm_shutdown_during_switch_to_off A test which verifies that a launch manager shutdown signalled via SIGTERM does not cancel existent switches to off. Currently does not fail, but should fail. As switch to off gets cancelled and reinitiated by launch manager code. Let test fail, as switch to off is cancelled by lm Revert to 1s timeout for lm shutdown & add some comments Still not 100% stable. Fix cherry pick odyssey Former fix for SIGSEGV of old branch

Other ControlClientMocks need to be updated separately.

WilliamRoebuck · 2026-08-18T07:55:20Z

+    # Run the launch manager until component_a signals it is stalling mid-termination
+    # (file `component_a_terminating`): the switch to run_target_c is then in progress
+    # but run_target_c has not been activated yet. run_until_file_deployed stops the
+    # launch manager at that point by sending it a SIGTERM (to the launch manager
+    # process only, so it performs its own orderly shutdown) and asserts it exits
+    # cleanly (code 0).


Suggested change

# Run the launch manager until component_a signals it is stalling mid-termination

# (file `component_a_terminating`): the switch to run_target_c is then in progress

# but run_target_c has not been activated yet. run_until_file_deployed stops the

# launch manager at that point by sending it a SIGTERM (to the launch manager

# process only, so it performs its own orderly shutdown) and asserts it exits

# cleanly (code 0).

# Run until `component_a_terminating` is deployed so we can request shutdown during

# the transition to run target c

cameron-craig-etas · 2026-08-18T08:15:10Z

+    // TODO: adopt this in the remaining tests/integration/*/*control*.cpp binaries
+    // that still wait with a bare pause().


Do we have a Github issue for this? We could make sure we have one and remove this TODO.

WilliamRoebuck

Looks good now, my only remaining concerns are the core dump and test wait changes

WilliamRoebuck · 2026-08-18T07:57:43Z

+    # Run the launch manager until component_a signals it is stalling mid-termination
+    # (file `component_a_terminating`): the explicit switch to Off is then in progress.
+    # run_until_file_deployed stops the launch manager at that point by sending it a
+    # SIGTERM (to the launch manager process only, so it performs its own orderly
+    # shutdown) and asserts it exits cleanly (code 0).


Suggested change

# Run the launch manager until component_a signals it is stalling mid-termination

# (file `component_a_terminating`): the explicit switch to Off is then in progress.

# run_until_file_deployed stops the launch manager at that point by sending it a

# SIGTERM (to the launch manager process only, so it performs its own orderly

# shutdown) and asserts it exits cleanly (code 0).

# Run until `component_a_terminating` is deployed so we can send SIGTERM

# to launch manager during the transition to Off

WilliamRoebuck · 2026-08-18T08:06:09Z

+  ```
+  The default `core_pattern` differs per system (e.g. `|/wsl-capture-crash ...`
+  on WSL, `|/lib/systemd/systemd-coredump ...` on systemd hosts, or plain
+  `core`). Check yours *before* the first run so you know the value to restore.


If this is important to do before running, we should put this operation under a config flag I think. Its very unlikely that anyone will see this before they run tests the first time (after this PR)

WilliamRoebuck · 2026-08-18T08:15:48Z

+/// @brief How long the process stalls while being terminated, keeping an in-progress
+/// run-target switch alive so the test has a deterministic window to send SIGTERM to
+/// the launch manager. Must be smaller than the configured shutdown_timeout so the


Suggested change

/// @brief How long the process stalls while being terminated, keeping an in-progress

/// run-target switch alive so the test has a deterministic window to send SIGTERM to

/// the launch manager. Must be smaller than the configured shutdown_timeout so the

/// @brief How long the process stalls while being terminated.

/// Must be smaller than the configured shutdown_timeout so the

WilliamRoebuck · 2026-08-18T08:37:38Z

+    /// Poll the atomic flag instead of calling pause() directly. A process-directed
+    /// signal (from kill) is delivered to an arbitrary one of the process's threads
+    /// that has the signal unblocked. If the test process has more than one thread
+    /// (e.g. a ControlClient, whose constructor spawns a background IPC thread), the
+    /// handler may run on a background thread and set exitRequested there. pause()
+    /// only returns for a signal handled on the calling thread, so a main thread
+    /// blocked in pause() would not wake - it would stay parked until the launch
+    /// manager SIGKILLs it at its shutdown_timeout, and never write its XML result.
+    /// Polling observes the flag regardless of which thread handled the signal.


Ah, but I think that is the key difference. From my testing, a pause on the main thread always takes precedence to pauses on child threads. Though this might be OS dependent. I think this should be a separate issue/PR anyway as it is not needed for this test.

github-project-automation Bot added this to LCM - Lifecycle & Health FT Aug 11, 2026

github-project-automation Bot moved this to Backlog in LCM - Lifecycle & Health FT Aug 11, 2026

TimoSteuerwaldETAS requested a deployment to workflow-approval August 11, 2026 11:03 — with GitHub Actions Waiting

TimoSteuerwaldETAS force-pushed the feature/shutdown_tests branch from f064618 to bee9de9 Compare August 11, 2026 11:48

TimoSteuerwaldETAS requested a deployment to workflow-approval August 11, 2026 11:48 — with GitHub Actions Waiting

TimoSteuerwaldETAS requested a deployment to workflow-approval August 11, 2026 11:49 — with GitHub Actions Waiting

TimoSteuerwaldETAS requested a deployment to workflow-approval August 13, 2026 08:18 — with GitHub Actions Waiting

TimoSteuerwaldETAS requested a deployment to workflow-approval August 13, 2026 10:48 — with GitHub Actions Waiting

TimoSteuerwaldETAS requested a deployment to workflow-approval August 13, 2026 11:54 — with GitHub Actions Waiting

TimoSteuerwaldETAS force-pushed the feature/shutdown_tests branch from 66c58a4 to 3494414 Compare August 13, 2026 12:23

TimoSteuerwaldETAS requested a deployment to workflow-approval August 13, 2026 12:23 — with GitHub Actions Waiting

TimoSteuerwaldETAS marked this pull request as ready for review August 13, 2026 12:27

TimoSteuerwaldETAS requested review from FScholPer, MaciejKaszynski, NicolasFussberger, anmittag, antonkri, pawelrutkaq and ramceb as code owners August 13, 2026 12:27

TimoSteuerwaldETAS requested a review from WilliamRoebuck August 13, 2026 12:28

TimoSteuerwaldETAS force-pushed the feature/shutdown_tests branch from 3494414 to 3f23834 Compare August 13, 2026 12:53

TimoSteuerwaldETAS requested a deployment to workflow-approval August 17, 2026 13:47 — with GitHub Actions Waiting

TimoSteuerwaldETAS requested a review from WilliamRoebuck August 17, 2026 13:51

TimoSteuerwaldETAS added 21 commits August 17, 2026 18:25

Add crashdump support in docker environment

bc94443

Log PID

9a9ab81

Proposed fix by Claude.

91f4ea6

Increase shutdown_timeout

d0bcd24

Revert FAIL

a9e272f

Honor the termination timeout during shutdown

a9093d2

Add method to TestRunner

f21b9a9

Other ControlClientMocks need to be updated separately.

Only check shutdown timeout of currently active runtarget

21af048

Consider only the shutdown timeout of active processes

1254591

Format fix

946988f

Reconstruct file paths automatically

8dcfb20

Align to naming schema on main branch

97555b1

Update requirement name

ec20ef6

Change log level

868ac8b

Shrink comments & tiny adaptions

0e83ae1

Refactor code to simply use run_until_file_deployed(..)

7edc8c0

Get rid of identical component_a.cpp files.

64c11e8

Update comment regarding deinit order

e9a2611

Move control client mocks -> test driver

4ddf7dc

Update references to control_client_test_driver

63c02af

TimoSteuerwaldETAS force-pushed the feature/shutdown_tests branch from 98dcd34 to 63c02af Compare August 17, 2026 16:36

TimoSteuerwaldETAS requested a deployment to workflow-approval August 17, 2026 16:36 — with GitHub Actions Waiting

WilliamRoebuck reviewed Aug 18, 2026

View reviewed changes

cameron-craig-etas suggested changes Aug 18, 2026

View reviewed changes

WilliamRoebuck reviewed Aug 18, 2026

View reviewed changes

Navigation Menu

Uh oh!

Add tests which are verifying comp_req__launch_man__launcher_exit_shutdown - #450

Add tests which are verifying comp_req__launch_man__launcher_exit_shutdown#450
TimoSteuerwaldETAS wants to merge 21 commits into
eclipse-score:mainfrom
etas-contrib:feature/shutdown_tests

TimoSteuerwaldETAS commented Aug 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

WilliamRoebuck Aug 18, 2026 •

edited

Loading

Uh oh!

cameron-craig-etas Aug 18, 2026

Uh oh!

WilliamRoebuck left a comment

Uh oh!

WilliamRoebuck Aug 18, 2026

Uh oh!

WilliamRoebuck Aug 18, 2026

Uh oh!

WilliamRoebuck Aug 18, 2026

Uh oh!

WilliamRoebuck Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// TODO: adopt this in the remaining tests/integration//control*.cpp binaries
		// that still wait with a bare pause().

Uh oh!

Conversation

TimoSteuerwaldETAS commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

WilliamRoebuck Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cameron-craig-etas Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

WilliamRoebuck left a comment

Choose a reason for hiding this comment

Uh oh!

WilliamRoebuck Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

WilliamRoebuck Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

WilliamRoebuck Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

WilliamRoebuck Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TimoSteuerwaldETAS commented Aug 11, 2026 •

edited

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading

WilliamRoebuck Aug 18, 2026 •

edited

Loading