Skip to content

Include slf4j.simple with version range in platform products #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HannesWell merged 1 commit into from
Oct 18, 2026
Merged

Include slf4j.simple with version range in platform products #4100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions products/eclipse-platform/platform.p2.inf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,9 @@ properties.1.value = 4.42 Release of the Eclipse Platform.

properties.2.name = org.eclipse.equinox.p2.provider
properties.2.value = Eclipse.org

# Specify this as a requirement with a version range rather than as <plugin id="slf4j.simple"/> in the product.
# This way we can specify a version range that allows the logger bundle to be updated without requiring the product to be updated.
requires.1.namespace = org.eclipse.equinox.p2.iu
requires.1.name = slf4j.simple
requires.1.range = [2.0.0,3.0.0)

@HannesWell HannesWell Oct 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we should restrict the range to just [2.0.0,2.1.0)?
If there is a severe security or bug-fix available, I expect it to happen with a service version increment.

@merks merks Oct 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the range smaller lead to more maintenance effort should the minor version change for whatever reason.

The bundle has major version ranges on it's slf4j.api requirements:

image

We don't actually use any API directly anywhere, though I'm not sure what WTP is doing with it:

image

There are no narrow version ranges restrictions elsewhere.

So I can't think of any reason why we would create a narrow version range. What problem might it prevent that justifies restricting the resolution space?

@HannesWell HannesWell Oct 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I can't think of any reason why we would create a narrow version range. What problem might it prevent that justifies restricting the resolution space?

In general I thought maybe an undesired feature could be added. But usually slf4j is quiet conservative so that concern is not very likely to materialize.

2 changes: 1 addition & 1 deletion products/eclipse-platform/platform.product
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ United States, other countries, or both.
</license>

<plugins>
<plugin id="slf4j.simple"/>
<!-- Contains also slf4j.simple, but defined vis p2.inf to include it with a version range -->
</plugins>

<features>
Expand Down
6 changes: 6 additions & 0 deletions products/eclipse-sdk/sdk.p2.inf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,9 @@ properties.1.value = 4.42 Release of the Eclipse SDK.

properties.2.name = org.eclipse.equinox.p2.provider
properties.2.value = Eclipse.org

# Specify this as a requirement with a version range rather than as <plugin id="slf4j.simple"/> in the product.
# This way we can specify a version range that allows the logger bundle to be updated without requiring the product to be updated.
requires.1.namespace = org.eclipse.equinox.p2.iu
requires.1.name = slf4j.simple
requires.1.range = [2.0.0,3.0.0)
2 changes: 1 addition & 1 deletion products/eclipse-sdk/sdk.product
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ United States, other countries, or both.
</license>

<plugins>
<plugin id="slf4j.simple"/>
<!-- Contains also slf4j.simple, but defined vis p2.inf to include it with a version range -->
</plugins>

<features>
Expand Down
Loading