Repository navigation
Include slf4j.simple with version range in platform products - #4100
Conversation
| # This way we can specify a version range that allows the logger bundle to be updated without requiring the product to be updated. | ||
| requires.1.namespace = org.eclipse.equinox.p2.iu | ||
| requires.1.name = slf4j.simple | ||
| requires.1.range = [2.0.0,3.0.0) |
There was a problem hiding this comment.
Or maybe we should restrict the range to just [2.0.0,2.1.0)?
If there is a severe security or bug-fix available, I expect it to happen with a service version increment.
There was a problem hiding this comment.
Making the range smaller lead to more maintenance effort should the minor version change for whatever reason.
The bundle has major version ranges on it's slf4j.api requirements:
We don't actually use any API directly anywhere, though I'm not sure what WTP is doing with it:
There are no narrow version ranges restrictions elsewhere.
So I can't think of any reason why we would create a narrow version range. What problem might it prevent that justifies restricting the resolution space?
There was a problem hiding this comment.
So I can't think of any reason why we would create a narrow version range. What problem might it prevent that justifies restricting the resolution space?
In general I thought maybe an undesired feature could be added. But usually slf4j is quiet conservative so that concern is not very likely to materialize.
This mirrors what the EPP is doing for products that contains slf4j.simple as their logging backend, in order to be able to update slf4j independently of the product:
This is a follow-up to
FYI @merks