Repository navigation
fix: fail chart render when walReplica uses the unpublished image - #480
Closed
guanzhousongmicrosoft wants to merge 1 commit into
Closed
guanzhousongmicrosoft wants to merge 1 commit into
guanzhousongmicrosoft wants to merge 1 commit into
Conversation
guanzhousongmicrosoft
requested review from
WentingWu666666,
alaye-ms,
hossain-rayhan and
xgerman
as code owners
October 19, 2026 13:05
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes consistently update image resolution, chart validation, tests, and documentation, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Removes incompatible ChangeStreams image fallbacks and prevents Helm from deploying WAL replica without an explicit image tag.
Changes:
- Uses standard image resolution regardless of the ChangeStreams gate.
- Requires
image.walreplica.tagwhen WAL replica is enabled. - Updates regression tests and image-resolution documentation.
| File | Description |
|---|---|
| operator/src/internal/webhook/documentdb_webhook.go | Updates image-resolution comments. |
| operator/src/internal/webhook/documentdb_webhook_test.go | Checks default version with ChangeStreams enabled. |
| operator/src/internal/utils/util.go | Removes ChangeStreams image override logic. |
| operator/src/internal/utils/constants.go | Removes personal-registry image constants. |
| operator/src/internal/product/documentdb.go | Updates shared resolver calls. |
| operator/src/internal/product/documentdb_test.go | Checks standard ChangeStreams image defaults. |
| operator/documentdb-helm-chart/values.yaml | Documents WAL replica image requirements. |
| operator/documentdb-helm-chart/tests/03_wal_replica_test.yaml | Tests required tags and explicit overrides. |
| operator/documentdb-helm-chart/templates/03_documentdb_wal_replica.yaml | Rejects enabled WAL replica without a tag. |
| docs/designs/image-management.md | Updates image-resolution precedence. |
Review effort: Balanced
Member
Author
|
Closing in favour of #481. |
guanzhousongmicrosoft
force-pushed
the
developer/1.0-image-fallbacks
branch
2 times, most recently
from
October 19, 2026 15:28
fa55d12 to
01ccc3d
Compare
guanzhousongmicrosoft
changed the title
guanzhousongmicrosoft
force-pushed
the
developer/1.0-image-fallbacks
branch
from
October 19, 2026 15:33
01ccc3d to
6aca6ca
Compare
Signed-off-by: Guanzhou Song <guanzhousong@microsoft.com>
guanzhousongmicrosoft
force-pushed
the
developer/1.0-image-fallbacks
branch
from
October 19, 2026 15:37
6aca6ca to
ba39daa
Compare
guanzhousongmicrosoft
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #481.
walReplica: truedeploysghcr.io/documentdb/…/wal-replica:<appVersion>. That image was never published, so the pod sits in ImagePullBackOff. The chart now fails at render time when the image resolves to that repository. A customimage.registryorimage.walreplica.repositorystill works.