Skip to content

fix(lint): resolve staticcheck S1008 and ST1005 findings #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 2 commits into from
Aug 4, 2026
+4 −6
Merged

fix(lint): resolve staticcheck S1008 and ST1005 findings #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18ef72b
fix(lint): resolve staticcheck S1008 and ST1005 findings
skevetter Aug 4, 2026
20b43a6
refactor(lint): rename ErrLoftNotReachable to ErrPlatformNotReachable
skevetter Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cmd/pro/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ func (cmd *StartCmd) waitForLoftDocker(ctx context.Context, containerID string)
if cmd.NoTunnel {
return "", fmt.Errorf(
"%w: %s",
ErrLoftNotReachable,
ErrPlatformNotReachable,
"cannot connect to Devsy Pro as it has no exposed port and --no-tunnel is enabled",
)
}
Expand Down Expand Up @@ -2174,7 +2174,8 @@ func getHelmWorkdir(chartName string) (string, error) {

var (
ErrMissingContainer = errors.New("missing container")
ErrLoftNotReachable = errors.New("Devsy Pro is not reachable")
//nolint:staticcheck // ST1005: "Devsy Pro" is a proper noun
ErrPlatformNotReachable = errors.New("Devsy Pro is not reachable")
)

type ContainerDetails struct {
Expand Down
5 changes: 1 addition & 4 deletions pkg/tunnel/services.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,10 +258,7 @@ func RunServices(ctx context.Context, opts RunServicesOptions) error {
Factor: retryFactor,
Jitter: retryJitter,
}, func(err error) bool {
if ctx.Err() != nil {
return false
}
return true
return ctx.Err() == nil
}, func() error {
return runServicesIteration(ctx, opts, forwardedPorts, resolver)
})
Expand Down
Loading