fix(lint): resolve staticcheck S1008 and ST1005 findings - #877
Conversation
- pkg/tunnel/services.go: simplify the retry.OnError predicate to `return ctx.Err() == nil` (S1008). - cmd/pro/start.go: suppress ErrLoftNotReachable's ST1005 (capitalized error string) since "Devsy Pro" is a proper noun, not a fixable style issue. No behavior changes.
✅ Deploy Preview for images-devsy-sh canceled.
|
✅ Deploy Preview for devsydev canceled.
|
|
Warning Review limit reached
Next review available in: 5 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change adds a proper-noun lint suppression and simplifies the ChangesLint suppression
Retry predicate simplification
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Matches the current Devsy Platform naming; "Loft" is legacy.
1f65d48 to
20b43a6
Compare
Summary
Fixes the two smallest
staticcheckfindings, grouped together since each is a one-line fix:pkg/tunnel/services.go: simplifies theretry.OnErrorpredicate fromif ctx.Err() != nil { return false }; return truetoreturn ctx.Err() == nil(S1008).cmd/pro/start.go: suppressesErrLoftNotReachable's ST1005 finding (capitalized error string) with a//nolint-- "Devsy Pro" is a proper noun, not a fixable style issue.No behavior changes. The remaining
staticcheckfindings (8SA1019deprecation warnings) point at larger API migrations (MCP SDK logging, legacy shell-injection path, k8s httpstream) and are out of scope -- tracked separately, not suppressed, so they stay visible.Summary by CodeRabbit
Bug Fixes
Chores