Skip to content

fix(meerkat-dbm): use fixed positioning for runner iframes #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gal-podlipnik merged 1 commit into from
Oct 7, 2026
Merged

fix(meerkat-dbm): use fixed positioning for runner iframes #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions meerkat-dbm/src/dbm/dbm-parallel/iframe-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface IFrameManagerConstructor {
uuid: string;
onMessage: (
runnerId: string,
message: WindowMessage<BrowserRunnerMessage>
message: WindowMessage<BrowserRunnerMessage>,
) => any;
}

Expand All @@ -33,13 +33,20 @@ export class IFrameManager {
this.iframe = document.createElement('iframe');
this.iframe.src = `${runnerURL}?uuid=` + uuid + '&origin=' + origin;
const runnerDomain = new URL(runnerURL).origin;
document.body.appendChild(this.iframe);

//Move the iframe out of the screen
this.iframe.style.position = 'absolute';
this.iframe.style.left = '-10000px';
this.iframe.style.top = '0';
this.iframe.style.visibility = 'hidden';
// Hidden worker host, kept as a zero-size fixed box inside the viewport
Object.assign(this.iframe.style, {
position: 'fixed',
top: '0',
left: '0',
width: '0',
height: '0',
border: '0',
visibility: 'hidden',
pointerEvents: 'none',
});

document.body.appendChild(this.iframe);

this.communication = new WindowCommunication<BrowserRunnerMessage>({
targetWindow: this.iframe.contentWindow as Window,
Expand Down
Loading