Skip to content

Fix freeze and zoom capture on newer wlroots screencopy stacks #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devmobasa merged 1 commit into from
Jun 8, 2026
Merged

Fix freeze and zoom capture on newer wlroots screencopy stacks #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/backend/wayland/backend/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ use wayland_protocols_wlr::screencopy::v1::client::zwlr_screencopy_manager_v1::Z

use super::super::state::{WaylandGlobals, WaylandState};

// Freeze/zoom capture currently consumes wl_shm buffer events and ignores linux-dmabuf.
// Version 3 can negotiate linux-dmabuf-only frames on newer wlroots/NVIDIA stacks, so
// bind through v2 until dmabuf capture is implemented.
const MAX_SHM_SCREENCOPY_VERSION: u32 = 2;

pub(super) struct WaylandSetup {
pub(super) conn: Connection,
#[cfg(tablet)]
Expand Down Expand Up @@ -108,7 +113,11 @@ pub(super) fn setup_wayland() -> Result<WaylandSetup> {
debug!("Pointer constraints global not available");
}

let screencopy_manager = match globals.bind::<ZwlrScreencopyManagerV1, _, _>(&qh, 1..=3, ()) {
let screencopy_manager = match globals.bind::<ZwlrScreencopyManagerV1, _, _>(
&qh,
1..=MAX_SHM_SCREENCOPY_VERSION,
(),
) {
Ok(manager) => {
debug!("Bound zwlr_screencopy_manager_v1");
Some(manager)
Expand Down Expand Up @@ -148,3 +157,13 @@ pub(super) fn setup_wayland() -> Result<WaylandSetup> {
layer_shell_available,
})
}

#[cfg(test)]
mod tests {
use super::MAX_SHM_SCREENCOPY_VERSION;

#[test]
fn screencopy_binding_stays_on_wl_shm_compatible_version() {
assert_eq!(MAX_SHM_SCREENCOPY_VERSION, 2);
}
}
Loading