Fix freeze and zoom capture on newer wlroots screencopy stacks#247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #241
Fixes freeze/zoom capture on newer Sway/wlroots setups by binding the wlroots screencopy protocol through version 2 instead of version 3.
Wayscriber currently consumes
wl_shmscreencopy buffer events. Screencopy v3 can negotiatelinux_dmabufframes, which Wayscriber does not handle yet, causing capture-driven features like freeze and zoom to fail on affected stacks.Changes
ZwlrScreencopyManagerV1binding to the wl_shm-compatible v2 path