Skip to content

fix(timeline): keep point config in sync with number of posts - #161

Merged
ralvarez-dg merged 2 commits into
mainfrom
fix/-timeline-add-elements
Nov 3, 2026
Merged

ralvarez-dg merged 2 commits into
mainfrom
fix/-timeline-add-elements

Conversation

@timothy-mugo

Copy link
Copy Markdown
Contributor

…-894)

The 'Number of Posts' control saved a config built from the previous count, so adding posts left the saved config shorter than the post list and the front end crashed. Build the config for the new count, and repair short configs already saved in existing blocks when the editor loads.

Description

Type of change

  • Bug fix (fix:)
  • New feature (feat:)
  • Breaking change (BREAKING CHANGE:)
  • Refactor / chore (refactor: / chore:)
  • Documentation update (docs:)

Affected package(s)

  • @devgateway/dvz-wp-commons
  • @devgateway/create-wp-customizer
  • @devgateway/upgrade-wp-customizer
  • plugins/wp-react-blocks-plugin
  • plugins/wp-react-custom-api
  • plugins/wp-react-custom-rest-menu
  • Other plugin / theme / Docker (no changeset needed)

Checklist

  • PR title follows Conventional Commits format
  • pnpm build passes locally
  • No hardcoded credentials, internal URLs, client names, or PII introduced
  • Any new dependency has a GPL-2.0-or-later-compatible license (MIT, BSD, Apache-2.0, ISC are all compatible)

Copilot AI lite review requested due to automatic review settings November 3, 2026 11:11
@timothy-mugo timothy-mugo changed the title fix(timeline): keep point config in sync with number of posts (TCDIKE… fix(timeline): keep point config in sync with number of posts Nov 3, 2026
The 'Number of Posts' control saved a config built from the previous count, so
adding posts left the saved config shorter than the post list and the front end
crashed. Build the config for the new count, and repair short configs already
saved in existing blocks when the editor loads.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The changeset targets an unrelated published package for a plugin-only change, which can create an incorrect release entry or disrupt release planning.

1 open issue
What changed in this PR

This pull request keeps timeline point configurations synchronized with the selected number of posts and repairs short configurations in existing blocks to prevent front-end failures.

Changes:

  • Synchronizes point configuration in both timeline block editors.
  • Creates missing configuration entries when the post count increases.
  • Repairs incomplete saved configurations when blocks load.
  • Adds release metadata for the fix.

This pull request requires changes.

File Review
plugins/​wp-react-blocks-plugin/​blocks/​time-line/​BlockEdit.js Moderate issue (1 vote): New point configurations omit the legacy tooltipFontColor: "#fff" default, which may affect tooltip rendering.
plugins/​wp-react-blocks-plugin/​blocks/​new-time-line/​BlockEdit.js Applies configuration synchronization and repair behavior to the newer timeline block.
.changeset/​calm-points-sync.md Nit (4 votes): Targets the unrelated @devgateway/dvz-wp-commons package; plugin-only changes do not require a changeset.

Review effort: Lite

Comment thread .changeset/calm-points-sync.md Resolved
@timothy-mugo
timothy-mugo force-pushed the fix/-timeline-add-elements branch from 3f1ce12 to cff116a Compare November 3, 2026 11:16
Copilot AI lite review requested due to automatic review settings November 3, 2026 11:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Resolved since last review (1)
  • ✅ .changeset/calm-points-sync.md#L2 — Resolved by @​timothy-mugo - This changeset targets @​devgateway/dvz-wp-commons, but the modified files are in the private…

@timothy-mugo

Copy link
Copy Markdown
Contributor Author

UI PR: devgateway/data-viz-ui#303

@ralvarez-dg
ralvarez-dg merged commit c5e36c5 into main Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants