Repository navigation
fix(timeline): keep point config in sync with number of posts - #161
Merged
Merged
Conversation
The 'Number of Posts' control saved a config built from the previous count, so adding posts left the saved config shorter than the post list and the front end crashed. Build the config for the new count, and repair short configs already saved in existing blocks when the editor loads.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changeset targets an unrelated published package for a plugin-only change, which can create an incorrect release entry or disrupt release planning.
1 open issue
What changed in this PR
This pull request keeps timeline point configurations synchronized with the selected number of posts and repairs short configurations in existing blocks to prevent front-end failures.
Changes:
- Synchronizes point configuration in both timeline block editors.
- Creates missing configuration entries when the post count increases.
- Repairs incomplete saved configurations when blocks load.
- Adds release metadata for the fix.
This pull request requires changes.
| File | Review |
|---|---|
plugins/wp-react-blocks-plugin/blocks/time-line/BlockEdit.js |
Moderate issue (1 vote): New point configurations omit the legacy tooltipFontColor: "#fff" default, which may affect tooltip rendering. |
plugins/wp-react-blocks-plugin/blocks/new-time-line/BlockEdit.js |
Applies configuration synchronization and repair behavior to the newer timeline block. |
.changeset/calm-points-sync.md |
Nit (4 votes): Targets the unrelated @devgateway/dvz-wp-commons package; plugin-only changes do not require a changeset. |
Review effort: Lite
timothy-mugo
force-pushed
the
fix/-timeline-add-elements
branch
from
November 3, 2026 11:16
3f1ce12 to
cff116a
Compare
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Resolved since last review (1)
- ✅ .changeset/calm-points-sync.md#L2 — Resolved by @timothy-mugo - This changeset targets
@​devgateway/dvz-wp-commons, but the modified files are in the private…
Contributor
Author
|
UI PR: devgateway/data-viz-ui#303 |
Merged
8 of 14 tasks
ralvarez-dg
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

…-894)
The 'Number of Posts' control saved a config built from the previous count, so adding posts left the saved config shorter than the post list and the front end crashed. Build the config for the new count, and repair short configs already saved in existing blocks when the editor loads.
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-wp-commons@devgateway/create-wp-customizer@devgateway/upgrade-wp-customizerplugins/wp-react-blocks-pluginplugins/wp-react-custom-apiplugins/wp-react-custom-rest-menuChecklist
pnpm buildpasses locally