Repository navigation
fix(timeline): don't crash when posts outnumber saved point configs - #303
Merged
Merged
Conversation
Per-point settings were read as config[idx].x, which throws once a post is added beyond the saved data-config array. Add getPointConfig() that falls back to the last configured point, then defaults, and make subtitle reads null-safe.
Merged
6 of 16 tasks
commit: |
Contributor
Author
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The patch addresses the reported timeline crash and missing-subtitle scenarios across all timeline variants with shared fallback settings and null-safe rendering.
No open issues 🎉
What changed in this PR
This pull request prevents timeline rendering crashes when posts exceed the saved per-point configuration entries and safely handles missing subtitles.
Changes:
- Added shared point configuration defaults and fallback resolution.
- Updated all timeline variants to use safe point configuration access.
- Made subtitle rendering null-safe.
- Added a patch changeset.
| File | Description |
|---|---|
packages/dvz-ui/src/embeddable/time-line/point-config.js |
Defines default point settings and fallback resolution for missing configuration entries. |
packages/dvz-ui/src/embeddable/time-line/mobile.jsx |
Applies fallback settings and safely renders missing subtitles on mobile. |
packages/dvz-ui/src/embeddable/time-line/desktop.jsx |
Applies fallback settings and safely renders missing subtitles on desktop. |
packages/dvz-ui/src/embeddable/new-time-line/timeline.jsx |
Applies shared fallback settings and null-safe subtitle rendering. |
.changeset/quiet-points-grow.md |
Documents the patch release for the timeline crash fix. |
Review effort: Lite
ralvarez-dg
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-point settings were read as config[idx].x, which throws once a post is added beyond the saved data-config array. Add getPointConfig() that falls back to the last configured point, then defaults, and make subtitle reads null-safe.
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-ui-react@devgateway/wp-react-libexampleonly (no changeset needed)Checklist
pnpm changeset) for any change to a published packagepnpm buildpasses locallypnpm --filter @devgateway/* typecheckpasses