Repository navigation
fix(cli): --window no longer brings Programa to the front (INC-488) - #542
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global
--windowflag used to sendwindow.focusbefore every command. That raised and activated the app, which breaks the rule that CLI commands never steal focus.Now the CLI checks that the window exists and routes the command to it with
window_id, unless the command already names a workspace, surface or tab.Also new:
--password-stdinreads the socket password from stdin so it stays out ofps.--passwordstill works, and its help text now warns aboutps.Intentional test contract change in
tests/test_cli_registry_behavior.py:--window W pingnow sendswindow.listthensystem.pinginstead ofwindow.focus.Known gaps:
current-windowandtreeignore--window, because their handlers don't takewindow_idyet. Not checked against a running app.Fixes INC-488