Repository navigation
refactor: split the CLI command table into CLI/Commands (INC-494) - #545
Merged
Merged
Conversation
…he table once (INC-494)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI behaves the same as before, with one exception:
clear-notifications --helpnow says it clears the current workspace unless--windowis given.commandDescriptors()was a single 2,722-line function. It is now a short assembler, and the descriptors live in nine files underCLI/Commands. Codex config handling moved out ofCLI+Hooks.swiftintoCLI+CodexConfig.swift.29 legacy validation arms moved onto descriptor grammars. 10 remain (their descriptors are in
CLI+Tree,CLI+HookCommandsandCLI+TmuxCompat); that is tracked as a follow-up. The command table is now built once per process instead of up to three times.Before rebasing onto main, a 288-case help and error diff against main matched except for
clear-notifications. After the rebase the build succeeds and the help text from #542 (--password-stdin, "without focusing") is still present. Structural caps forCLI/programa.swift(3200) andCLI/CLI+Hooks.swift(2600) are lowered to match.Linear: INC-494