Repository navigation
i18n(uk): add Ukrainian translation - #3
Conversation
Added Ukrainian localization strings for the application.
The branch was written against v0.5.8. Since then `clipboard_log_template` was dropped (v0.6.0, no longer logging password details) and the strength tooltip added nine fields (v0.5.9), so `strings_uk` no longer compiled. Drop the stale field, translate the tooltip strings, and use a decimal comma as Ukrainian does. Also list Ukrainian in the README and restore the newline before the closing </description> tag. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
PR #3 sat mergeable-but-broken for a week because nothing checked it: it was written against v0.5.8 and `strings_uk` no longer matched the current `I18nStrings`. A plain `cargo test` would have said so on day one. Also validate the desktop entry and the AppStream metainfo, since both are hand-edited for every new translation and only Flathub notices when they are wrong. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Thank you for this, and sorry for the slow reply — the translation itself is good work, and the The branch was based on v0.5.8, and two things changed in the meantime, so
Git merged your branch cleanly, which is why it looked fine here — the breakage only shows up at compile time, and there was no CI to catch it. That's on me: I've added a workflow ( Since "allow edits by maintainers" was enabled, I pushed the update to your branch rather than making you redo it. Two commits, no history rewritten, so a plain
I would appreciate a second pair of eyes on the strings I added, since I don't speak Ukrainian and these are the ones I filled in rather than you: chars_unit: "символів",
entropy_label: "Ентропія",
bits_unit: "біт",
crack_time_label: "Офлайнова атака",
crack_time_note: "Припущення: 10¹² спроб/с (швидке гешування, потужний GPU)",
strength_labels: ["Дуже слабкий", "Слабкий", "Прийнятний", "Надійний", "Дуже надійний"],
time_units: ["с", "хв", "год", "днів", "років"],
time_instant: "миттєво",
decimal_separator: ",",They render as one tooltip on the password field, e.g. One question on your own strings: Once you've had a look at the wording I'll merge this and it'll go out with the next release. |
- Merged the Ukrainian translation contributed by Dymkom in #3, brought up to the current I18nStrings: the strength tooltip strings were missing and the clipboard log string removed in v0.6.0 was still being set - Added a CI workflow that builds, tests and validates the desktop entry and AppStream metadata on every push and pull request
|
@danst0, hi! Thank you for the detailed explanation and for taking care of the updates. I see the PR is already merged! The new workflow for catching compilation errors sounds like a great addition. |
- crack_time_note now reads "швидкий алгоритм, потужний ГП" instead of "швидке гешування, потужний GPU", per review by Dymkom, who contributed the Ukrainian translation in #3 - The remaining strings I filled in were confirmed as correct, including the decimal comma and "Складові" for the character-set section
|
Thank you — that's exactly the kind of review I was hoping for.
crack_time_note: "Припущення: 10¹² спроб/с (швидкий алгоритм, потужний ГП)",
On the plurals: you're right that there's no pluralization engine, the strings are plain Thanks again for the translation and for coming back to check the strings I filled in. |
No description provided.