Skip to content

fix(csv): validate the shape of saved datasets (02-2.4) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daggerok merged 1 commit into from
Oct 13, 2026
Merged

fix(csv): validate the shape of saved datasets (02-2.4) #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,11 @@ function loadPersistedDataSets(): DataSet[] | null {
const raw = localStorage.getItem(LOCALSTORAGE_DATA_KEY);
if (!raw) return null;
const parsed = JSON.parse(raw);
if (Array.isArray(parsed) && parsed.length > 0) return parsed as DataSet[];
// A damaged or foreign record (e.g. {"dataSets": "x"}) must not reach the table code: check the DataSet shape
const valid = Array.isArray(parsed) && parsed.length > 0 && parsed.every((d: any) =>
d && typeof d.fileName === 'string' && Array.isArray(d.data) && d.data.every((row: unknown) => Array.isArray(row)));
if (valid) return parsed as DataSet[];
if (parsed !== null) console.warn('[RememberData] Ignoring persisted datasets with an unexpected shape');
return null;
} catch (err) {
console.warn('[RememberData] Failed to load persisted datasets:', err);
Expand Down
Loading