Repository navigation
fix(csv): validate the shape of saved datasets (02-2.4) - #5
Merged
Merged
Conversation
loadPersistedDataSets returned any non-empty JSON array from
localStorage, so a damaged or foreign record reached the table code and
failed there (.map is not a function). It now restores only an array of
{ fileName: string, data: string[][] } and otherwise starts empty, the
path an empty store already takes
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan 02 item 2.4 (csv part), with the check fixed to the real
DataSettypeWhat
loadPersistedDataSetsrestores only an array of{ fileName: string, data: string[][] }; anything else returnsnull(the existing "nothing stored" path) and logs a warningWhy
The plan's check (
d.rows,d.headers) does not matchinterface DataSet { fileName: string; data: string[][]; }and would have rejected every valid saved set; its find block also occurs twice (NEEDS_BOOT_RESTOREonly checks the length, so it was left as is)Checks run
bun install -E,bun run build,git diff --check{"dataSets":"x"}, rows/headers shape,datanot an array, a row not an array,[null],[],null, broken JSON, nothing stored): valid ones restore, the rest return null{fileName, data:"x"}crashed the old build (blank page,TypeError: ec.rows.map is not a function) and loads cleanly with this change; no console errors