test: handle Windows UDP fixture port reuse - #27
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Windows job can pass while the regression test skips; it must verify exactly five passes and zero skips.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Test-only update making UDP fixture handling Windows-aware and adding repeated Windows regression coverage.
Changes:
- Uses platform-aware bind-error classification.
- Adds a five-run Windows UDP test job.
- The job must reject skipped tests and verify five actual passes.
| File | Description |
|---|---|
internal/tunnel/datagram_icmp_recovery_test.go |
Classifies reused fixture ports across platforms. |
.github/workflows/ci.yml |
Adds targeted Windows UDP testing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation
Local targeted race tests, five repetitions: passed.
Windows amd64 test-binary cross-compilation: passed (not Windows runtime evidence).
Formatting, diff checks and independent review: passed.
Exact final head
55a52ae20a26a74e09ba20d96b34c56b3a034ee7: CI 35809975977 (all 11 jobs including container integration and OCI), CodeQL 35809975945 and Linux netem 35809975965 succeeded.Windows job 107019143907 successfully ran the JSON gate and explicitly verified five actual passes and zero skips for each top-level test. Review request addressed and resolved.
Merged main
83c97e384cefe25520868ab6a049216f0a1a1f7fmatches the tested tree. CI 35810196873 (all 11 jobs including Docker/OCI), CodeQL 35810196849 and Linux netem 35810196857 succeeded. Windows merge job 107019834706 again explicitly verified five passes and zero skips for both tests.Evidence boundary
The regression checks default-socket continuity. It does not assert reception or recovery of a particular ICMP/socket error; the Windows job is a targeted runtime check, not the full Windows suite. No release/tag.