test: cover native UDP continuity after closed destinations - #26
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add Windows-aware handling for WSAEADDRINUSE during port-reuse detection.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds a native UDP regression test for association continuity after sends to closed loopback destinations.
Changes:
- Tests healthy UDP replies before and after closed-port attempts.
- Verifies payload, source address, and association continuity.
- Adds bounded cleanup and port-reuse handling.
| File | Summary |
|---|---|
internal/tunnel/datagram_icmp_recovery_test.go |
Adds the native UDP continuity regression test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation
make checkandmake race: passed.TestQUICDatagram*tests repeated 10 times, 120 top-level passes, zero failures/skips.d20d618fc4775859a01e60c4b1bb1e2aecb4ec3d: CI 35809096247 (all 10 jobs), CodeQL 35809096226 and Linux netem 35809096313 succeeded.39138289ca4b6335d22bb8f49a7d99160dc0429fhas the identical tested tree; CI 35809274000 (all 10 jobs, including container integration/OCI), CodeQL 35809274013 and Linux netem 35809273992 succeeded.Scope and evidence limits
Test-only: no runtime, protocol, dependency or default changes. This verifies continuity in the exercised environments; it does not establish delivery of ICMP to an unconnected socket or observation of any particular errno. Separate ignored congestion-control experiments are not part of this PR. No release/tag.