Skip to content

Trim remaining shape-only tests (CL-7475) #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Sep 15, 2026
Merged

Trim remaining shape-only tests (CL-7475) #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions packages/sandbox-sidecar/src/provisioner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,34 +88,6 @@ describe("ensure request validation", () => {
expect(result).toEqual({ kind: "accepted", externalRef: "unit-2" });
});

test("rejects a negative generation", async () => {
const provisioner = makeProvisioner();

const result = await provisioner.ensure(
baseEnsureRequest({ generation: -1 }),
);

expect(result).toMatchObject({
kind: "rejected",
code: "invalid_ensure_request",
});
expect(started).toHaveLength(0);
});

test("rejects a non-integer generation", async () => {
const provisioner = makeProvisioner();

const result = await provisioner.ensure(
baseEnsureRequest({ generation: 1.5 }),
);

expect(result).toMatchObject({
kind: "rejected",
code: "invalid_ensure_request",
});
expect(started).toHaveLength(0);
});

test("still rejects a stale generation once fencing has observed a later one", async () => {
const provisioner = makeProvisioner();

Expand Down Expand Up @@ -145,19 +117,4 @@ describe("destroy request validation", () => {

expect(result).toEqual({ kind: "destroyed" });
});

test("rejects a negative generation", async () => {
const provisioner = makeProvisioner();

const result = await provisioner.destroy({
allocationId: "alloc-1",
sidecarId: "sidecar-1",
generation: -1,
});

expect(result).toMatchObject({
kind: "rejected",
code: "invalid_destroy_request",
});
});
});
2 changes: 0 additions & 2 deletions scripts/e2e/harness.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ describe("workflowDeployBody", () => {
sourceOfferingIds: ["offering-1", "offering-2"],
defaultSourceOfferingId: "offering-1",
});
expect(body).not.toHaveProperty("sources");
expect(body).not.toHaveProperty("defaultSource");
});
});

Expand Down
42 changes: 0 additions & 42 deletions workflows/assistant/test/definition.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,6 @@ test("the agent carries the assistant prompt, the preferences, and inlines no to
expect(agent.toolFactories).toEqual([]);
});

test("the agent carries the tool package pins as declared", () => {
const agent = assistantStep(buildAssistantWorkflow(INPUT)).agent;
expect(agent.toolPackagePins).toEqual(ASSISTANT_TOOL_PACKAGE_PINS);
});

test("the workflow pins manus-tools and does not require a Manus credential binding", () => {
const definition = buildAssistantWorkflow(INPUT);
expect(ASSISTANT_TOOL_PACKAGE_PINS.map((pin) => pin.name)).toContain(
Expand Down Expand Up @@ -130,40 +125,3 @@ test("a non-positive or fractional turn timeout is rejected", () => {
buildAssistantWorkflow({ ...INPUT, turnTimeoutMs: 0.5 }),
).toThrow(/turnTimeoutMs/);
});

// CL-6179: on a stated outcome, Myra runs a short, bounded discovery
// interview before proposing anything — never the open-ended intake
// this clause exists to rule out.
test("the prompt runs discovery inside 'Deciding what to do', in order: interview, propose, build, hand off", () => {
const decidingSection = ASSISTANT_SYSTEM_PROMPT.slice(
ASSISTANT_SYSTEM_PROMPT.indexOf("## Deciding what to do"),
ASSISTANT_SYSTEM_PROMPT.indexOf("## Being a teammate"),
);

const interviewAt = decidingSection.indexOf("ask one or two sharp questions");
const proposeAt = decidingSection.indexOf(
"propose a small, named specialist team",
);
const buildAt = decidingSection.indexOf("Build only on a light confirmation");
const skillAt = decidingSection.indexOf("load the writing-system-prompts");
const createAgentAt = decidingSection.indexOf("create_agent");
const handoffAt = decidingSection.indexOf(
"Their own chats for focused work.",
);

for (const at of [
interviewAt,
proposeAt,
buildAt,
skillAt,
createAgentAt,
handoffAt,
]) {
expect(at).toBeGreaterThan(-1);
}
expect(interviewAt).toBeLessThan(proposeAt);
expect(proposeAt).toBeLessThan(buildAt);
// The skill loads before create_agent ever fires.
expect(skillAt).toBeLessThan(createAgentAt);
expect(createAgentAt).toBeLessThan(handoffAt);
});
Loading