Repository navigation
Trim remaining shape-only tests (CL-7475) - #711
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-7475-trim-shape-tests
branch
from
September 15, 2026 16:17
33629a1 to
91edd58
Compare
Drop assertions that re-state literals instead of proving behavior: harness workflowDeployBody key absence (toEqual already pins the body), assistant prompt sentence order + tautological pin echo (pins check owns versions), provisioner negative/non-integer generations (guard restates itself). Tool-package shapes already trimmed under PR 666.
TheGreatAxios
force-pushed
the
cl-7475-trim-shape-tests
branch
from
September 15, 2026 16:34
91edd58 to
e40c430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: delete the shape-only tests CL-7475 names that still remain on main; the tool-package shapes already landed via PR 666 (commit 251d76e, orphaned by the re-pin rewrite but its deletions are present in this base).
Why: Sawyer ruling 2026-09-06 — test only logic that is ours and not obviously correct; these cases re-state literals instead of proving behavior.
Deletion proof (87 deletions, 0 additions across 3 files):
Verification: workflows/assistant 12 pass, sandbox-sidecar 23 pass, catalog-tools+access-tools 36 pass, harness.test.ts 10 pass; typecheck exit 0; eslint + prettier clean on touched files; check:structural ok. Full bun run check stops at a pre-existing prettier warning in VENDORED.md (touched by base commit 5281117, not this diff) — left untouched, parent call.
Fixes CL-7475