Repository navigation
Make the new-workbench composer intent-first - #658
Merged
TheGreatAxios merged 6 commits intoSep 7, 2026
Merged
Conversation
pratikbuilds
marked this pull request as draft
September 6, 2026 10:24
pratikbuilds
changed the title
pratikbuilds
force-pushed
the
fix/workbench-chat-composer
branch
from
September 6, 2026 10:35
e2dd3aa to
fd62988
Compare
pratikbuilds
force-pushed
the
fix/workbench-chat-composer
branch
from
September 6, 2026 10:45
fd62988 to
d00b6b3
Compare
… de-flake search tests Three review fixes: - Enter inside the agent search with zero matches no longer falls through to the form's implicit submission, which created a workbench the operator did not ask for; the keydown is now always cancelled and a picker test asserts the cancellation (red without the fix). - The workbench-create catch reported only the post-create failure branch through reportError; every other cause now reports with operation context and the toast carries the refId. - The use-entity-search debounce test asserted a transient that evaporates once the 5ms debounce timer outruns the assertion on a loaded runner (two CI failures, unreproducible locally); a gated source now holds loading observable deterministically. - agent-turns: the sectionRunId doc matches the per-agent warm run.
TheGreatAxios
marked this pull request as ready for review
September 7, 2026 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesign the new-workbench chat composer as the primary way to start a workbench.
Supporting reliability
Validation
bun run typecheckbun run lintbun run test