Repository navigation
feat(web): chip agent picker with search and Create agent; scoped New Agent drawer (CL-8477) - #895
Merged
Merged
Conversation
… Agent drawer (CL-8477)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new-workbench-picker.tsxwith a chip-based agent picker: removable chips for selected agents, a search popover ("+ Add agent") with keyboard nav (arrows/Enter/Escape), and a filled/checked state on selected options — restoring the design from Make the new-workbench composer intent-first #658.CreateAgentPanelinline; on successful deploy the new agent is auto-selected and the agent list is invalidated so it shows up immediately (restoring Add agent creation to the workbench composer picker #693, minus the removed template/invitable-definitions plumbing that no longer exists on this screen).create-agent-panelclass from Fix New Agent drawer clipping and scrollbar overlap #691 are already present oncreate-agent-panel.tsx/app.cssin this branch — no changes needed there.Verified
bunx tsc -p apps/web --noEmitbun run lintbun run fmtcd apps/web && bun run buildbun test apps/web/src(515 pass; 69 pre-existing failures unrelated to this change —document/windownot defined in a subset of test files run outside their DOM harness, same failures reproduce on files this PR never touches)Not verified
react-ui candidates
useDismissablePopover+ listbox/combobox markup) is generic enough to be a reusablereact-uicomponent if another picker needs the same search-and-chip pattern.