Repository navigation
feat(tool): add a waiting status for a call held on other work - #168
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Notes:
Triage will approve, label. |
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
A call can be held on something outside it, such as a hand-off whose run is paused on its own approval. The only waiting status, approval-requested, means the call itself is the question, so a host had to mark such a call as asking and got an approval card with no decision behind it. waiting draws as a plain row with a pause icon and the word "Waiting", overridable through statusLabels. It folds into activity runs like any step that is not asking. A tool group counts it as neither done nor running and reads as held, as it does for a call waiting on a person.
TheGreatAxios
force-pushed
the
cl-12173-no-dead-approval-card
branch
from
November 6, 2026 01:46
10d8a49 to
2bd011a
Compare
TheGreatAxios
changed the title
Contributor
Author
|
Closing: Builder no longer needs this. The step it was for will be redesigned instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A step can now be waiting: held on something outside it, without being the question itself. Until now the only waiting status was
approval-requested, which means "this step is asking the person" and draws an approval card. A step that was only held, like a hand-off whose started work is paused on its own approval, had to pretend to be running or pretend to be asking.waitingstatus: a normal row with a pause icon and the label "Waiting", which apps can rename. No card, no buttons, and it folds into activity runs like any other step.The real question stays the "Install zod" card. Approving it still continues the work (screenshot).
Adds a status but removes or renames nothing. An app that switches over every status will need a
waitingcase.Verification
waiting: one card each time, the step reads "Paused", and approving continues. 2 runs with it shown as running read "Working" with a spinner, for comparison.