Repository navigation
fix(web): show one approval card while a specialist waits on an approval - #198
Conversation
|
Moving back into draft; upon a deeper review the change in value on the approval key looks to be a possible bypass around the https://github.com/corbitsdev/react-ui library that may require a small tweak related to the approval API. |
A hand-off whose run was held on an approval was marked approval-requested, which tells the thread that the hand-off call itself is asking the person. It is not: the run's own approval, such as an install, is already in the same message with its card. So the thread drew a second, default card for the hand-off whose buttons did nothing, and took the step out of its activity, which hid the "Paused for your approval" line. The hand-off now reads as running while its run waits, so the real approval is the only card and the paused line shows.
505bd2b to
8f38120
Compare
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
Not a bypass. The issue was on our side. We marked the "Started the app builder" step as approval-requested, which react-ui draws as an approval card, but that step has nothing to approve. It now shows as running while its work is held, so only the real install card appears. One line, verified 2× on main and 2× on this branch. Also: corbitsdev/react-ui#168 adds a waiting status, so once 0.6.0 is out, the opened step can read "Paused" instead of "Working". |
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
What changed
When the app builder stops to ask "Install zod into your app?", the conversation showed two approval cards: the real one, and a second one on the "Started the app builder" step whose Approve and Deny buttons did nothing. The "Paused for your approval" line was also missing. Now only the real card shows, under "Paused for your approval".
Why: Builder marked the "Started the app builder" step as asking for approval whenever the app builder was held on one. The UI reads that status as "this step is the question", so it drew a card for it. There was nothing to decide on that step, so its buttons went nowhere. The real question is the install card. The step now shows as still in progress while the app builder waits.
One line in
work-unit.ts, plus the existing test updated.Verification
Closes CL-12173