Repository navigation
feat(hub): share approval packages and record reviewer decisions - #60
Conversation
74984df to
7550f81
Compare
Nothing triage asked to change still fails, so this request no longer stands.
7550f81 to
e1a6357
Compare
|
Sharing a package and recording a reviewer decision match the PR. A decision is stored only on a reviewer id that belongs to the round for that tenant and project, and the round keeps the package version and sha256 it was started with. A reviewer id from another round is 404. Two gaps:
|
e1a6357 to
322cc7e
Compare
Nothing triage asked to change still fails, so this request no longer stands.
76de76e to
c4c6561
Compare
c4c6561 to
f3cbc0c
Compare
f3cbc0c to
6eb1635
Compare
6eb1635 to
7f8bd7d
Compare
Nothing triage asked to change still fails, so this request no longer stands.
7f8bd7d to
9af73aa
Compare
9af73aa to
2d3691b
Compare
# Conflicts: # apps/hub/src/db/migrations/meta/0036_snapshot.json # apps/hub/src/db/migrations/meta/_journal.json # apps/hub/src/db/schema.ts
8fdca54 to
788a631
Compare
|
Triage: Unsure Asking a maintainer about:
Stacked on #59: only this pull request's own changes were checked. |
Nothing triage asked to change still fails, so this request no longer stands.
Closes CL-11934 (Slice 4 of 5 for CL-11929; stacked on
cl-11933-add-a-presenter-that-builds-a-package-for-one-audience).Summary
GET /api/tenants/:tenantId/projects/:projectId/packages/:version/zipusing@corbits/zipto deterministically bundledeck.pptx,deck.pdf,README.md,manifest.json, and groundeddocuments/<kind>.md.approval_roundtable inapps/hub/src/db/schema.tsand migration0036_approval_round.sql) with no idle parked workflow holding a sidecar slot.@corbits-builder/clientmethods to start an approval round (recording the project owner's approval of thatapproval_packageversion), record or amend reviewer decisions (approve,request_changes,commentwith overall and per-slide notes), and settle a round.ContextualApprovalRoundsreading-pane UI (apps/web/src/pages/workspace/approval-rounds.tsx) with zip download, native file share sheet, round creation, per-reviewer decision recording, and settlement.