Skip to content

feat(hub): triage reviewer feedback and forward approved items - #61

Merged
TheGreatAxios merged 1 commit into
cl-11934-share-a-package-and-record-reviewers-decisionsfrom
cl-11935-send-triaged-feedback-to-the-coordinator
Nov 2, 2026
Merged

TheGreatAxios merged 1 commit into
cl-11934-share-a-package-and-record-reviewers-decisionsfrom
cl-11935-send-triaged-feedback-to-the-coordinator

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Closes CL-11935 (Slice 5 of 5 for CL-11929; stacked on cl-11934-share-a-package-and-record-reviewers-decisions).

Summary

  • Extract structured triage bullet items (summary, targetKind, slideNumber, status: "pending" | "incorporated" | "dismissed" | "replied") when reviewer feedback is recorded (apps/hub/src/artifacts/approval-rounds.ts), without automatically messaging the Coordinator.
  • Add person-only POST /:projectId/approval-rounds/:roundId/triage/:itemId endpoint (Incorporate, Dismiss, Reply) so the project owner reads and gates all reviewer feedback first.
  • When the project owner chooses Incorporate, forward the feedback item to the active Coordinator as the owner in a clearly delimited external block (--- reviewer feedback (external, <name>, <persona>, package v<N>) ---) naming the target document kind (apps/hub/src/config/approval-rounds.ts).
  • Render the owner feedback triage list in apps/web/src/pages/workspace/approval-rounds.tsx with Incorporate, Dismiss, and Reply actions.

@linear-code

linear-code Bot commented Nov 2, 2026

Copy link
Copy Markdown

CL-11935

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • CI green: required checks are failing

@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch from 830ab87 to 308807a Compare November 2, 2026 02:41
@corbits-triage
corbits-triage Bot dismissed their stale review November 2, 2026 02:43

Nothing triage asked to change still fails, so this request no longer stands.

corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 2, 2026
@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch from 308807a to f13dbd9 Compare November 2, 2026 03:40
corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 2, 2026
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

The gate holds. Only an owner Incorporate mails the coordinator, and it mails that one stored bullet. Recording a decision, dismiss, and reply do not.

Two gaps:

  1. The mail does not name the package version or the reviewer's decision. incorporatedFeedbackMessage in apps/hub/src/config/approval-rounds.ts sends persona, reviewer, and slide. The coordinator prompt expects package version, audience, reviewer, decision, and note. A note on an older package can be applied to the wrong generation.

  2. Incorporate is not once-only. triageItem checks pending, mails, then writes incorporated as separate steps. A double-click, or a mail that succeeds before the status write, sends the same bullet twice. The 409 only applies after a successful write.

@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch from f13dbd9 to a1da1b6 Compare November 2, 2026 05:07
@corbits-triage
corbits-triage Bot dismissed stale reviews from themself November 2, 2026 05:09

This pull request is no longer ready to approve, so this approval no longer stands.

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Errors kept: added code matches a code pattern
    • apps/hub/src/artifacts/approval-rounds.ts:1127-1129 bare-catch: A catch without a binding drops the error; check for the expected failure, or catch it and rethrow the rest.

corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 2, 2026
@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch from 6033887 to 588e29b Compare November 2, 2026 08:28
@corbits-triage
corbits-triage Bot dismissed their stale review November 2, 2026 08:28

This pull request is no longer ready to approve, so this approval no longer stands.

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Conventions: added code matches a code pattern
    • apps/web/src/pages/workspace/approval-rounds.tsx:2042 empty-list-fallback: Invented fallback `?? []`; handle the missing value instead.
    • apps/web/src/pages/workspace/approval-rounds.tsx:2050-2062 promise-chain: Promise chain; use async/await with try/catch.
    • apps/web/src/pages/workspace/approval-rounds.tsx:2050-2061 promise-chain: Promise chain; use async/await with try/catch.

@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch from 588e29b to 3d659d3 Compare November 2, 2026 08:40

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Conventions: added code matches a code pattern
    • apps/web/src/pages/workspace/approval-rounds.tsx:2061 empty-list-fallback: Invented fallback `?? []`; handle the missing value instead.
    • apps/web/src/pages/workspace/approval-rounds.tsx:2069-2081 promise-chain: Promise chain; use async/await with try/catch.
    • apps/web/src/pages/workspace/approval-rounds.tsx:2069-2080 promise-chain: Promise chain; use async/await with try/catch.
    • apps/web/src/pages/workspace/approval-rounds.tsx:2175-2177 promise-chain: Promise chain; use async/await with try/catch.
    • apps/web/src/pages/workspace/approval-rounds.tsx:2178-2183 promise-chain: Promise chain; use async/await with try/catch.
    • apps/web/src/pages/workspace/approval-rounds.tsx:2184-2194 promise-chain: Promise chain; use async/await with try/catch.
    • apps/web/src/pages/workspace/approval-rounds.tsx:2184-2191 promise-chain: Promise chain; use async/await with try/catch.

@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch from 3d659d3 to 9ed2f51 Compare November 2, 2026 08:46
@corbits-triage
corbits-triage Bot dismissed stale reviews from themself November 2, 2026 08:50

Nothing triage asked to change still fails, so this request no longer stands.

corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 2, 2026
@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch from 9ed2f51 to 17c6a3d Compare November 2, 2026 08:52
corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 2, 2026
@TheGreatAxios
TheGreatAxios added this pull request to stack #90 November 2, 2026 09:06
@corbits-triage
corbits-triage Bot dismissed their stale review November 2, 2026 09:09

This pull request is no longer ready to approve, so this approval no longer stands.

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Merge conflicts: merge conflicts with base

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • CI green: required checks are failing
    • typecheck

@corbits-triage

corbits-triage Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Stacked on #60: only this pull request's own changes were checked.

Notes:

  • mixes unrelated changes: apps/web/src/workspace-approvals-setting.ts

Triage will approve, request review.

corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant