Repository navigation
feat(hub): triage reviewer feedback and forward approved items - #61
Conversation
830ab87 to
308807a
Compare
Nothing triage asked to change still fails, so this request no longer stands.
308807a to
f13dbd9
Compare
|
The gate holds. Only an owner Incorporate mails the coordinator, and it mails that one stored bullet. Recording a decision, dismiss, and reply do not. Two gaps:
|
f13dbd9 to
a1da1b6
Compare
This pull request is no longer ready to approve, so this approval no longer stands.
6033887 to
588e29b
Compare
This pull request is no longer ready to approve, so this approval no longer stands.
There was a problem hiding this comment.
Triage requests changes:
- Conventions: added code matches a code pattern
apps/web/src/pages/workspace/approval-rounds.tsx:2042 empty-list-fallback: Invented fallback `?? []`; handle the missing value instead.apps/web/src/pages/workspace/approval-rounds.tsx:2050-2062 promise-chain: Promise chain; use async/await with try/catch.apps/web/src/pages/workspace/approval-rounds.tsx:2050-2061 promise-chain: Promise chain; use async/await with try/catch.
588e29b to
3d659d3
Compare
There was a problem hiding this comment.
Triage requests changes:
- Conventions: added code matches a code pattern
apps/web/src/pages/workspace/approval-rounds.tsx:2061 empty-list-fallback: Invented fallback `?? []`; handle the missing value instead.apps/web/src/pages/workspace/approval-rounds.tsx:2069-2081 promise-chain: Promise chain; use async/await with try/catch.apps/web/src/pages/workspace/approval-rounds.tsx:2069-2080 promise-chain: Promise chain; use async/await with try/catch.apps/web/src/pages/workspace/approval-rounds.tsx:2175-2177 promise-chain: Promise chain; use async/await with try/catch.apps/web/src/pages/workspace/approval-rounds.tsx:2178-2183 promise-chain: Promise chain; use async/await with try/catch.apps/web/src/pages/workspace/approval-rounds.tsx:2184-2194 promise-chain: Promise chain; use async/await with try/catch.apps/web/src/pages/workspace/approval-rounds.tsx:2184-2191 promise-chain: Promise chain; use async/await with try/catch.
3d659d3 to
9ed2f51
Compare
Nothing triage asked to change still fails, so this request no longer stands.
9ed2f51 to
17c6a3d
Compare
This pull request is no longer ready to approve, so this approval no longer stands.
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Stacked on #60: only this pull request's own changes were checked. Notes:
Triage will approve, request review. |
Closes CL-11935 (Slice 5 of 5 for CL-11929; stacked on
cl-11934-share-a-package-and-record-reviewers-decisions).Summary
summary,targetKind,slideNumber,status: "pending" | "incorporated" | "dismissed" | "replied") when reviewer feedback is recorded (apps/hub/src/artifacts/approval-rounds.ts), without automatically messaging the Coordinator.POST /:projectId/approval-rounds/:roundId/triage/:itemIdendpoint (Incorporate,Dismiss,Reply) so the project owner reads and gates all reviewer feedback first.Incorporate, forward the feedback item to the active Coordinator as the owner in a clearly delimited external block (--- reviewer feedback (external, <name>, <persona>, package v<N>) ---) naming the target document kind (apps/hub/src/config/approval-rounds.ts).apps/web/src/pages/workspace/approval-rounds.tsxwithIncorporate,Dismiss, andReplyactions.