Skip to content

ci: add the Corbits Triage policy - #2

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-11843-add-the-corbits-triage-policy-to-corbits-builder
Oct 31, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-11843-add-the-corbits-triage-policy-to-corbits-builder

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Closes CL-11843 (https://linear.app/abklabs/issue/CL-11843/add-the-corbits-triage-policy-to-corbits-builder).

Changes

Adds .corbits-triage.yml:

  • Process rules:
    • A linked GitHub or Linear issue is required. A pull request without one gets a comment to open an issue first, then is closed. Other failures request changes.
    • Also checked: Conventional Commits, CI green, no merge conflicts, no co-author lines or AI attribution, no hidden text, no duplicates. "Focused on one thing" only labels.
    • Rejected outright: node_modules, env files, dist, *.db, tmp/, .tmp/ and .data/.
  • Sensitive paths: vendor/, patches/, migrations and auth are high; CI, deploy and bun.lock are labelled.
  • Code rules on added code:
    • Fail: the convention preset (IIFEs, promise chains, empty catches, nested ternaries, ?? 0, ?? [], suppression comments).
    • Fail: a catch without a binding, or one whose error is neither used nor rethrown.
    • Fail: reaching vendored Interchange source by path, through an import, re-export or dynamic import.
    • Fail: invented empty fallbacks (|| [], || {}, ?? {}, empty strings, || 0), except inside string building and arithmetic.
    • Ask a maintainer: hand-rolled sleeps, and the interface opening a stream outside openSharedEventSource.
  • Actions: approve passing pull requests from thegreataxios and brianjfox; assign unsure ones to thegreataxios.
  • Off: code review and size checks.

Verification

  • Triage's policy reader (policy-check-action) reports the file as valid.
  • Triage's local check (cli.ts check) was run on a throwaway commit:
    • It failed or flagged every code rule: path import, bare catch, dropped error, invented fallback, Bun.sleep and new WebSocket.
    • It passed 1 + (n || 0) and ${s ?? ""}.
  • An independent review's findings are fixed.
  • CI passed.

@linear-code

linear-code Bot commented Oct 31, 2026

Copy link
Copy Markdown

CL-11843

@TheGreatAxios
TheGreatAxios marked this pull request as ready for review October 31, 2026 07:58
@TheGreatAxios
TheGreatAxios force-pushed the cl-11843-add-the-corbits-triage-policy-to-corbits-builder branch from 7f7df75 to b123f2f Compare October 31, 2026 08:01
@TheGreatAxios
TheGreatAxios merged commit b123f2f into main Oct 31, 2026
2 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-11843-add-the-corbits-triage-policy-to-corbits-builder branch October 31, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant