Skip to content

fix(web): show one approval card while a specialist waits on an approval #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Nov 6, 2026
Merged

fix(web): show one approval card while a specialist waits on an approval #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/web/src/pages/workspace/dispatch-status.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ test("a run held on an approval reads as paused for the person, not as at work",
expect(dispatchLive(coder, room("approval"))).toBe(true);
});

test("the hand-off's own step shows the approval wait instead of running", () => {
test("the hand-off's own step does not ask the person while its run waits on an approval", () => {
const [unit] = workUnits([{ at: 100, dispatch: coder }], [], []).units;
if (unit === undefined) throw new Error("no unit");
const message = workUnitMessage(unit, { state: "approval" });
const [step] = message.parts;
expect(step).toMatchObject({
kind: "tool-trace",
toolCallId: "call-coder",
status: "approval-requested",
status: "running",
});
// Nothing streams while the person is the one being waited on.
expect(message.status).toBe("sent");
Expand Down
3 changes: 2 additions & 1 deletion apps/web/src/pages/workspace/work-unit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ const CALL_STATUS: Record<DispatchStatus["state"], ToolTraceStatus> = {
declined: "output-denied",
starting: "pending",
working: "running",
approval: "approval-requested",
// The approval has its own card; a hand-off marked as asking would draw a second, dead one.
approval: "running",
ready: "output-available",
finished: "output-available",
failed: "error",
Expand Down