Skip to content

fix(web): give a decline with files the typed words as its reason #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheGreatAxios wants to merge 1 commit into from
Closed

fix(web): give a decline with files the typed words as its reason #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/web/src/pages/workspace/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,9 +850,8 @@ function ReadyRoom({
setFiles((current) => [...current, ...fitting]);
};

const deliverFiles = async (): Promise<boolean> => {
const deliverFiles = async (text = value.trim()): Promise<boolean> => {
if (sending) return false;
const text = value.trim();
const attached = files;
setSending(true);
setSendFailed(false);
Expand Down Expand Up @@ -1106,6 +1105,7 @@ function ReadyRoom({
};
const sendFiles = async () => {
if (sending) return false;
const text = value.trim();
const currentApprovals = await readPendingApprovals();
const currentOpen = currentApprovals?.find(
(approval) => approval.packages === undefined,
Expand All @@ -1114,6 +1114,13 @@ function ReadyRoom({
openApprovalId: currentOpen?.approvalId,
decide: onDecideApproval,
deliver: deliverFiles,
...(text.length === 0
? {}
: {
decline: async (approvalId: string) =>
(await deliverMail(text, true, declineWith(approvalId))) &&
deliverFiles(""),
Comment on lines +1120 to +1122

@corbits-triage corbits-triage Bot Nov 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 · Removing a file during the decline does not stop it from uploading

Files are now uploaded only after the decline request finishes. Until then the attachment chips stay on screen, and their remove buttons do not appear to be disabled while sending. deliverFiles was created when the send started, so it uploads the file list from that moment. A file the person removes during the decline is still uploaded.

Open card, type text, attach two files, press send, then remove one file before the decline returns. Both files are uploaded.

Resolve this comment. Triage will not finish while it is open.

}),
});
};
const sendNow = () => {
Expand Down