Repository navigation
fix(web): give a decline with files the typed words as its reason - #190
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
TheGreatAxios
marked this pull request as draft
November 5, 2026 02:31
corbits-triage
Bot
added
Triage: Needs Human Review
and removed
Triage: Waiting for code review
labels
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
Comment on lines
+1120
to
+1122
| decline: async (approvalId: string) => | ||
| (await deliverMail(text, true, declineWith(approvalId))) && | ||
| deliverFiles(""), |
There was a problem hiding this comment.
P3 · Removing a file during the decline does not stop it from uploading
Files are now uploaded only after the decline request finishes. Until then the attachment chips stay on screen, and their remove buttons do not appear to be disabled while sending. deliverFiles was created when the send started, so it uploads the file list from that moment. A file the person removes during the decline is still uploaded.
Open card, type text, attach two files, press send, then remove one file before the decline returns. Both files are uploaded.
Resolve this comment. Triage will not finish while it is open.
A send with files while an approval card was open declined it with no reason and sent the words with the files, so the coordinator was told the person left no feedback. The words now go as the decline's reason and the files follow on their own; a send with no words keeps the bare decline.
TheGreatAxios
force-pushed
the
cl-12150-send-a-decline-that-includes-a-file-as-the-persons-feedback
branch
from
November 5, 2026 02:39
4f42353 to
a4fcb37
Compare
TheGreatAxios
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an approval card is open and the person sends text with files, the decline now carries the typed words as its reason and the files follow on their own. Before, it declined with no reason and sent the text with the files, so the coordinator was told the person left no feedback. A send with no words keeps the bare decline, and a send with no card open is unchanged.
Fixes CL-12150.
Verification
A throwaway check of
sendFileswiring throughdeliverWithOpenApproval, deleted afterwards:bun run lint,format:check,typecheckandtest(290 pass) pass.