Skip to content

refactor: drop unused deck helpers, approval package wording and styles #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 2 commits into from
Nov 4, 2026
Merged

refactor: drop unused deck helpers, approval package wording and styles #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca9d7aa
refactor(slidedeck): drop unused paint resolver and radius wrapper
TheGreatAxios Nov 4, 2026
18211b6
refactor(web): drop unused approval package wording and styles
TheGreatAxios Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/web/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,10 +638,8 @@ export const wording = {
loadingSlides: "Loading slides…",
slidesUnavailable:
"The slides could not load. Reload the page to try again.",
speakerNotes: "Speaker notes",
downloadPdf: "Download PDF",
openPdf: "Open PDF",
downloadPptx: "Download PPTX",
pdfTitle: "Approval package PDF preview",
pdfUnreadable: "The PDF in this package could not be read.",
manifest: {
Expand Down
15 changes: 0 additions & 15 deletions apps/web/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2232,21 +2232,6 @@ button[aria-disabled="true"] {
opacity: 0.8;
}

.approval-package-slide-notes {
padding: var(--space-3) var(--space-4);
border-radius: var(--radius-md);
border: 1px solid var(--wb-border);
background: color-mix(in srgb, var(--wb-muted) 50%, var(--wb-card));
font-size: 0.84375rem;
line-height: 1.55;
color: var(--wb-foreground);
}

.approval-package-slide-notes-label {
color: var(--wb-muted-foreground);
font-weight: 600;
}

.approval-package-pdf {
display: flex;
flex-direction: column;
Expand Down
7 changes: 0 additions & 7 deletions packages/slidedeck/src/check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,6 @@ export function resolveThemeHex(theme: Theme, color: string): string {
return raw.startsWith("#") ? raw.toUpperCase() : `#${raw.toUpperCase()}`;
}

export function resolvePaintHex(theme: Theme, paint: Paint): string {
if (typeof paint === "string") return resolveThemeHex(theme, paint);
const first = paint.stops[0];
if (!first) return resolveThemeHex(theme, "background");
return resolveThemeHex(theme, first.color);
}

function srgbChannelLuminance(byte: number): number {
const s = byte / 255;
if (s <= 0.04045) return s / 12.92;
Expand Down
9 changes: 1 addition & 8 deletions packages/slidedeck/src/pdf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,6 @@ function scaleRadius(radius: PdfRadius): PdfRadius {
];
}

function scaleRadiusToPt(
radius: PictureElement["radius"],
): PdfRadius | undefined {
if (radius === undefined) return undefined;
return scaleRadius(radius);
}

function richRunsToPdf(
theme: Theme,
text: RichText,
Expand Down Expand Up @@ -406,7 +399,7 @@ function renderPictureElement(
): PdfElement {
const box = pxBoxToPt(el);
const data = media.get(el.image).data;
const radius = scaleRadiusToPt(el.radius);
const radius = el.radius === undefined ? undefined : scaleRadius(el.radius);
const border = resolvePdfBorder(theme, el.border);
return {
type: "image",
Expand Down