Skip to content

refactor(hub): map project errors in the app error handler only #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Oct 31, 2026
Merged

refactor(hub): map project errors in the app error handler only #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 30 additions & 53 deletions apps/hub/src/artifacts/design-themes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,6 @@ const security = [
export function mountDesignThemeRoutes(app: Hono<TenantEnv>, db: DB["db"]) {
const readable = (actor: Actor, projectId: string) =>
authorizeProject(db, actor, projectId, "read");
const failure = (
c: { json: (body: unknown, status: 403 | 404) => Response },
error: unknown,
) => {
if (error instanceof ProjectError)
return c.json(
{ code: error.code, ...error.details },
error.status as 403 | 404,
);
throw error;
};

app.get(
"/:projectId/design-themes",
Expand All @@ -56,18 +45,14 @@ export function mountDesignThemeRoutes(app: Hono<TenantEnv>, db: DB["db"]) {
},
}),
async (c) => {
try {
await readable(actorOf(c), c.req.param("projectId"));
return c.json({
themes: DESIGN_THEMES.map(({ id, label, direction }) => ({
id,
label,
direction,
})),
});
} catch (error) {
return failure(c, error);
}
await readable(actorOf(c), c.req.param("projectId"));
return c.json({
themes: DESIGN_THEMES.map(({ id, label, direction }) => ({
id,
label,
direction,
})),
});
},
);

Expand All @@ -92,25 +77,21 @@ export function mountDesignThemeRoutes(app: Hono<TenantEnv>, db: DB["db"]) {
},
}),
async (c) => {
try {
const actor = actorOf(c);
await readable(actor, c.req.param("projectId"));
const [run] = await db
.select({ label: designConcept.label })
.from(principal)
.innerJoin(designConcept, eq(designConcept.runId, principal.refId))
.where(
and(
eq(principal.id, actor.principalId),
eq(designConcept.tenantId, actor.tenantId),
),
);
const theme = run && themeOf(run.label);
if (!theme) throw new ProjectError(404, "design_theme_not_found");
return c.json({ files: BUNDLES[theme.id] });
} catch (error) {
return failure(c, error);
}
const actor = actorOf(c);
await readable(actor, c.req.param("projectId"));
const [run] = await db
.select({ label: designConcept.label })
.from(principal)
.innerJoin(designConcept, eq(designConcept.runId, principal.refId))
.where(
and(
eq(principal.id, actor.principalId),
eq(designConcept.tenantId, actor.tenantId),
),
);
const theme = run && themeOf(run.label);
if (!theme) throw new ProjectError(404, "design_theme_not_found");
return c.json({ files: BUNDLES[theme.id] });
},
);

Expand All @@ -131,17 +112,13 @@ export function mountDesignThemeRoutes(app: Hono<TenantEnv>, db: DB["db"]) {
},
}),
async (c) => {
try {
await readable(actorOf(c), c.req.param("projectId"));
const themeId = c.req.param("themeId");
const files = Object.hasOwn(BUNDLES, themeId)
? BUNDLES[themeId]
: undefined;
if (!files) throw new ProjectError(404, "design_theme_not_found");
return c.json({ files });
} catch (error) {
return failure(c, error);
}
await readable(actorOf(c), c.req.param("projectId"));
const themeId = c.req.param("themeId");
const files = Object.hasOwn(BUNDLES, themeId)
? BUNDLES[themeId]
: undefined;
if (!files) throw new ProjectError(404, "design_theme_not_found");
return c.json({ files });
},
);
}
Loading