Repository navigation
refactor(hub): map project errors in the app error handler only - #17
Merged
TheGreatAxios merged 1 commit intoOct 31, 2026
Conversation
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve, request review. |
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
force-pushed
the
cl-11857-let-the-hubs-error-handler-map-project-errors-instead-of-per
branch
from
October 31, 2026 15:00
582c3bc to
ccc540e
Compare
TheGreatAxios
deleted the
cl-11857-let-the-hubs-error-handler-map-project-errors-instead-of-per
branch
October 31, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-11857
What changed
The artifact, design-theme and next-step routes drop their local
failure()helpers and the try/catch around each handler; project errors propagate toapp.onError, which already answers with the same status and{ code, ...details }. Non-project errors were already rethrown to it. The form-parse try/catch in the attachments handler stays.How it was verified
failure()andapp.onErrorproduce the same status and body; the three route sets mount under the app that registersonErrorand have no handler of their own.bun run lint,bun run typecheck,bun run format:checkandbun run test(66 pass) pass.