Repository navigation
fix(web): read approval-package decks with the slidedeck schema - #168
Merged
TheGreatAxios merged 3 commits intoNov 4, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-12110-read-approval-package-decks-with-the-slidedeck-schema
branch
from
November 4, 2026 21:26
4821003 to
9283fed
Compare
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 21:39
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Stacked on #167: only this pull request's own changes were checked. Notes:
|
TheGreatAxios
force-pushed
the
cl-12110-read-approval-package-decks-with-the-slidedeck-schema
branch
from
November 4, 2026 21:51
d027714 to
63846ea
Compare
TheGreatAxios
merged commit Nov 4, 2026
9c0a069
into
cl-12110-remove-swallowed-errors-unchecked-casts-and-iifes-from-the
9 checks passed
TheGreatAxios
added a commit
that referenced
this pull request
Nov 4, 2026
* fix(web): read approval-package decks with the slidedeck schema * fix(web): load approval slides lazily and keep packages readable * fix(web): show a line when the slides fail to load, not a crash
TheGreatAxios
added a commit
that referenced
this pull request
Nov 4, 2026
* fix(web): read approval-package decks with the slidedeck schema * fix(web): load approval slides lazily and keep packages readable * fix(web): show a line when the slides fail to load, not a crash
TheGreatAxios
added a commit
that referenced
this pull request
Nov 4, 2026
#167) * fix(web): surface swallowed errors and close the microphone on failure * fix(web): keep courtesy reads and damaged imports from failing loudly * refactor(web): name the invitation load instead of an IIFE * fix(web): toast every failed copy of a project's failure detail * fix(web): read approval-package decks with the slidedeck schema (#168) * fix(web): read approval-package decks with the slidedeck schema * fix(web): load approval slides lazily and keep packages readable * fix(web): show a line when the slides fail to load, not a crash * fix(web): handle missing room data instead of inventing it (#171) * fix(web): handle missing room data instead of inventing it * fix(web): start room reads early and keep unread decisions unknown * fix(web): name an approval without concepts instead of defaulting * fix(web): ask about a blank-named document by its tool * refactor(web): replace promise chains and IIFEs with named functions * fix(web): rethrow failures other than unreadable JSON or cache * refactor(web): replace promise chains and an IIFE with named functions * refactor(web): poll a subscription login with a query observer * fix(web): treat an unreadable refusal body as one without a code * fix(web): never hold the first paint on a failed cache restore * fix(web): keep a login poll running offline and out of the cache * refactor(web): share one version read between view and compare * fix(web): check untrusted JSON and hub values against their schemas * fix(web): check untrusted JSON and hub values against their schemas * fix(web): treat an unreadable session as an error, not a sign-out * fix(web): read a frame's missing text without inventing one * fix: refuse unreadable custom models and unknown login URLs (#170) * fix(client): read login base URLs from a map keyed by login plugin * fix(web): refuse unreadable custom models instead of sending null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of CL-12110: the approval-package deck casts from the Findings document (
approval-package-preview.tsxtheme, slides and blocks cast after only anisRecordcheck). Stacked on #167.The hub builds each deck with slidedeck's
validateDeck, but the preview read it through its own hand-written interfaces. This change makes the preview use the same definition.Changes
@corbits/slidedeckgains a./decksubpath export (the schema file imports only arktype), andapps/webdepends on it. A production build of the web app contains none of the PDF or PPTX writers.bundle.deckwithvalidateDeckand renders from slidedeck's types. The local deck interfaces,isRecord, the casts and branches the schema rules out are removed.approval-package-slides.tsx, the only module that imports the deck schema, and loads withReact.lazybehind a "Loading slides…" line. Building the schema costs about 150 ms (measured in Bun), so only pages that show slides pay it. In a production build the schema's strings appear only in the slides chunk.noSlideswording is removed. Validation is memoised.ApprovalPackageBundle.deckinpackages/schemasstaysRecord<string, unknown>: the hub parses it on every write and stored-package read, so tightening it there would change hub behaviour.Verification
URL.canParse, which sets a browser floor (Safari 17, Chrome 120, Firefox 115).themeortheme.fontswere given a full theme, since the schema requires one.bun run lint,format:check,typecheck,test,pins:verifyandvendor:verifypass.