Repository navigation
fix(web): surface swallowed errors and close the microphone on failure - #167
Merged
TheGreatAxios merged 8 commits intoNov 4, 2026
Conversation
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 21:23
This was referenced Nov 4, 2026
corbits-triage
Bot
dismissed
their stale review
November 4, 2026 21:40
Nothing triage asked to change still fails, so this request no longer stands.
TheGreatAxios
enabled auto-merge
November 4, 2026 22:26
TheGreatAxios
force-pushed
the
cl-12110-remove-swallowed-errors-unchecked-casts-and-iifes-from-the
branch
from
November 4, 2026 22:34
69a62c5 to
10cf13f
Compare
* fix(web): read approval-package decks with the slidedeck schema * fix(web): load approval slides lazily and keep packages readable * fix(web): show a line when the slides fail to load, not a crash
* fix(web): handle missing room data instead of inventing it * fix(web): start room reads early and keep unread decisions unknown * fix(web): name an approval without concepts instead of defaulting * fix(web): ask about a blank-named document by its tool
* fix(web): rethrow failures other than unreadable JSON or cache * refactor(web): replace promise chains and an IIFE with named functions * refactor(web): poll a subscription login with a query observer * fix(web): treat an unreadable refusal body as one without a code * fix(web): never hold the first paint on a failed cache restore * fix(web): keep a login poll running offline and out of the cache * refactor(web): share one version read between view and compare
* fix(web): check untrusted JSON and hub values against their schemas * fix(web): treat an unreadable session as an error, not a sign-out * fix(web): read a frame's missing text without inventing one * fix: refuse unreadable custom models and unknown login URLs (#170) * fix(client): read login base URLs from a map keyed by login plugin * fix(web): refuse unreadable custom models instead of sending null
TheGreatAxios
force-pushed
the
cl-12110-remove-swallowed-errors-unchecked-casts-and-iifes-from-the
branch
from
November 4, 2026 22:43
10cf13f to
c1de195
Compare
|
Merged before Triage finished on |
TheGreatAxios
disabled auto-merge
November 4, 2026 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the CL-12110 pull requests: the swallowed errors, the microphone leak and the floating promises from the Findings document.
Changes
openMicrophone. When theAudioContextfails after the microphone opens, its tracks are stopped and the context closed, so the microphone no longer stays on.ApiFailure: unreachable and 5xx are retryable and stay the loading screen's to show; any other failure is now toasted (before, every failure was dropped because it was a plainError). The fetch failure keeps its cause, and only aSyntaxErrorfrom a non-JSON auth body is ignored. A connection that drops while the body is read counts as unreachable too.project.json) or aSyntaxErrorto "invalid import"; anything else propagates.ApiFailuretakesErrorOptionsso the cause is kept.JSON.parsecatches invisible-chat.tsanddispatch-card.tsxcatch onlySyntaxError. ThesessionStoragecatches inmodel-setup.tsxlog the cause, asstored-preference.tsdoes.void causeandvoid receiptare gone, and the invitation load is a named function instead of an IIFE (Triage flagged it because the role-name catch sits inside it). The open-decisions re-read logs its cause and keeps the cached list.Turned out safe, changed for the pattern only
room-reload.ts:31: with no room on screen,loadProjectRoomalready fails the room query with the same cause, which shows the room fault. The reloader now logs instead of.catch(() => undefined).Left for the later CL-12110 pull requests: the JSON.parse catches that also need arktype (
design-preview,specialist-updates,seen-versions,run-stream) (untrusted JSON); the remaining promise chains,.catch()calls and IIFEs, includingApp.tsx'sgetHubSession/ensureWorkspacechains (promise chains). Dictation's microphone outliving an unmount duringopenMicrophonepredates this and belongs to CL-12096.Verification
AudioContextstops the microphone tracks; a bad PDF base64 shows the unreadable line and no download.bun run lint,format:check,typecheck,test,pins:verifyandvendor:verifypass.