Skip to content

fix(coder): report a missing browser instead of dying when $HOME/browsers is absent #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianjfox merged 1 commit into from
Nov 2, 2026
Merged

fix(coder): report a missing browser instead of dying when $HOME/browsers is absent #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions workflows/coder/check/check-app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,12 +653,22 @@ if (staticRoot) {

// The sandbox setup unpacks Chrome's headless shell under $HOME/browsers. A sandboxed process may not
// register Mach services, so Chrome runs as one process with its own sandbox off.
const [chrome] = await Array.fromAsync(
new Bun.Glob("chrome-headless-shell-*/chrome-headless-shell").scan({
cwd: join(homedir(), "browsers"),
absolute: true,
}),
);
// With no browser installed the folder is not there at all, which is the same finding.
const installedBrowsers = async () => {
try {
return await Array.fromAsync(
new Bun.Glob("chrome-headless-shell-*/chrome-headless-shell").scan({
cwd: join(homedir(), "browsers"),
absolute: true,
}),
);
} catch (error) {
if (error instanceof Error && "code" in error && error.code === "ENOENT")
return [];
throw error;
}
};
const [chrome] = await installedBrowsers();
if (!chrome) {
stop();
fail("browser", "nothing under $HOME/browsers");
Expand Down