Repository navigation
fix(coder): report a missing browser instead of dying when $HOME/browsers is absent - #106
Merged
Merged
Conversation
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve, request review. |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Waiting for CI
labels
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98
What
check-app reports "nothing under $HOME/browsers" when that folder does not exist, instead of dying on the glob.
Why
With no headless shell unpacked, the folder is absent and the glob over it threw
ENOENTbefore the check printed a checklist, so the coder saw a crash rather than the finding the check already has words for. Details in #98.Changes
workflows/coder/check/check-app.ts:installedBrowsersreads the folder and treats a missing one as an empty one; any other error is still thrown.