Skip to content

🤖 ci: require connection refused in the E2E MCP port check #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasK33 merged 1 commit into from
Sep 25, 2026
Merged

🤖 ci: require connection refused in the E2E MCP port check #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,13 @@ jobs:
test "$(code "-H \"Authorization: Bearer \$(cat /var/run/secrets/kubernetes.io/serviceaccount/token)\" $list")" = 403
test "$(code "$api/healthz")" = 200
pod_ip=$(kubectl -n coder-system get pod -l app=coder-k8s -o jsonpath='{.items[0].status.podIP}')
if probe "curl -s --max-time 5 http://$pod_ip:8090/healthz"; then
echo "MCP must not listen on the pod network" >&2
test -n "$pod_ip" || { echo "could not read the coder-k8s pod IP" >&2; exit 1; }
# MCP must not listen on the pod network: only "connection refused" (curl exit 7) passes.
# Any other result, including success or a timeout (28), fails.
mcp_rc=0
probe "curl -s --max-time 5 http://$pod_ip:8090/healthz" || mcp_rc=$?
if [ "$mcp_rc" -ne 7 ]; then
echo "MCP port check: want connection refused (curl exit 7) from $pod_ip:8090, got exit $mcp_rc" >&2
exit 1
fi
kubectl -n default delete pod e2e-authn-probe --wait=false
Expand Down
6 changes: 3 additions & 3 deletions hack/main_publish_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ func TestChangelogChannels(t *testing.T) {
}
}

// The release workflow does not set GORELEASER_CHANNEL, and GoReleaser fails a template that reads a missing
// .Env key ("map has no entry"). Every channel-dependent disable template must render for an unset channel,
// and pick the right pipes per channel.
// Both workflows set GORELEASER_CHANNEL, but GoReleaser fails a template that reads a missing .Env key ("map
// has no entry"), so every channel-dependent disable template must still render when the channel is unset
// (for example, a local run), and pick the right pipes per channel.
func TestReleaseAndImageChannels(t *testing.T) {
data, err := os.ReadFile("../.goreleaser.yaml")
if err != nil {
Expand Down
Loading