🤖 ci: require connection refused in the E2E MCP port check - #139
Merged
Merged
Conversation
The E2E step "Verify aggregated API authentication and authorization" passed its port 8090 check on any curl failure, including a timeout or an empty pod IP (which probes "http://:8090"). It now requires a non-empty pod IP and curl exit 7 (connection refused); any other exit code, success included, fails with the code in the message. Also reword the TestReleaseAndImageChannels comment: both workflows now set GORELEASER_CHANNEL, and the templates must still render when it is unset. Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_ Change-Id: I26ed39993c768cd4bca288ea4048ad895a4f7775
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #136 (from its final review).
What changed
.github/workflows/ci.yaml, E2E step "Verify aggregated API authentication and authorization": the check that MCP does not listen on the pod network passed on any curl failure. A timeout, a DNS error, or an empty pod IP (curl tohttp://:8090) all passed. It now requires the pod IP to be set and curl to exit 7 (connection refused); any other result fails with a message that names the exit code.hack/main_publish_test.go: the comment aboveTestReleaseAndImageChannelsstill said the release workflow does not setGORELEASER_CHANNEL; since 🤖 fix: render GoReleaser channel templates when GORELEASER_CHANNEL is unset #138 both workflows set it. The comment now says why the templates must still render when it is unset.Validation
A harness extracts the exact
probe()and port-check lines fromci.yamlwithyqand runs them underset -euo pipefailwith stubbedkubectlandcurl:mainactionlint v1.7.10,
make lintandgo test ./hackpass. The real check runs in this PR's Kind E2E.Terminal recording (vhs capture; timing approximate):
pc-demo.webm
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:medium• Cost:$1772.17