Skip to content

fix(ci): build the breaking-change baseline with the same path filter as the input #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoinetoussaint-byte merged 1 commit into from
Oct 11, 2026
Merged

fix(ci): build the breaking-change baseline with the same path filter as the input #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,9 +483,15 @@ jobs:
git archive origin/main module/services/accounts/proto | tar -x -C "${baseline}"
# Compare the owned module as one Buf image; the vendored option
# closure is a separate module, not a second public API to compare.
# Both sides are built with the same --path filter. The proto
# directory holds two buf modules (the owned API and the vendored
# option closure under vendor/), so an unfiltered baseline yields two
# images against the filtered input's one and buf refuses to compare.
buf build module/services/accounts/proto --path module/services/accounts/proto/saas -o "${baseline}/current.binpb"
buf build "${baseline}/module/services/accounts/proto" \
--path "${baseline}/module/services/accounts/proto/saas" -o "${baseline}/against.binpb"
buf breaking "${baseline}/current.binpb" \
--against "${baseline}/module/services/accounts/proto" \
--against "${baseline}/against.binpb" \
--config module/services/accounts/proto/buf.yaml --exclude-imports
- name: Execute declared generators and reject drift
working-directory: module/tools
Expand Down
Loading