Repository navigation
fix(ci): build the breaking-change baseline with the same path filter as the input - #1078
Merged
Merged
Conversation
… as the input #1052 added `vendor` as a second buf module under the accounts proto directory. The check built the current side with `--path .../saas` (one image) but compared it against the unfiltered baseline directory (two images), so buf refused to compare: "input contained 1 images, whereas against contained 2 images". main has been red on this step since 3eb4b10, and so is every pull request. Build the baseline into an image with the same filter and compare image to image. Verified locally against main (passes), against the pre-#1052 main (passes; #1052 was additive), and with a deleted RPC (fails, naming it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
Immutable module package → Reject breaking stable protobuf changesstep. It has been red onmainsince3eb4b10f(#1052), and it fails every pull request, including therelease: v0.0.94PR #1077.Cause
#1052 added
- path: vendoras a second buf module inmodule/services/accounts/proto/buf.yaml, for the vendored Runnable option closure. The check builds the current side with--path module/services/accounts/proto/saas, which gives one image. It then compared that against the baseline directory, which builds both modules, two images. buf refuses:#1052's own run passed because its baseline was the previous one-module
main.Fix
Build the baseline into an image with the same
--pathfilter, and compare image to image. The owned API surface being compared is unchanged.Verified locally (buf 1.73.0)
mainreproduces the failure.mainpasses.main(3eb4b10f~1) passes, which confirms Callable sources: OAuth2, declarations and receipted host operations #1052 was additive.DatasourceService.DeleteSourcefails, naming the RPC.Classification: fix at the owner (this repo's CI step). No
ignore/exceptwas added and no rule was weakened.🤖 Generated with Claude Code