Repository navigation
fix(manifest-guard): classify generated Go checksums as metadata - #11
Merged
Merged
Conversation
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest guard rejects a generated
go.sum.tmplcontaining checksums for a transitive test dependency, even when the generated service imports no GitHub client. service-go #128 reproduces this with Core's resources tests pulling go-github/v89.Classify the exact
go.sum.tmplbasename as checksum metadata, matching the scanner's existing treatment of plaingo.sum. Generated runtime source andgo.mod.tmplremain scanned. This is a fix at the shared scanner owner, reusing its existing source-type classification; no consumer exclusion, dependency deletion, or second scanner is introduced. Documentation updated:docs/manifest-guard.md.Validation: all scanner behavioral tests and conformance verification/run/workflow tests pass. New cases accept checksum metadata and still reject GitHub client references in both generated Go source and dependency declarations. Against the exact tracked service-go candidate, the old scanner fails on two checksum lines and the corrected scanner passes. No generated consumer files were edited. Fresh independent architecture/implementation review found no blocking findings at 9928ba2; it independently reproduced the consumer before/after and verified generated Git/GitHub/Argo violations remain detected. Hosted scan-test passed in run 40574673354.
This is the required owner correction for codefly-dev/service-go#128. The consumer will pin the reviewed merged commit; no other owner repository changes are included.