Repository navigation
fix(manifest-guard): retain Go binding declaration coverage - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlier binding matcher refinement stopped detecting ordinary Go declarations such as
var Branch = "main",var Revision = "HEAD", and inlinetype Source struct { Branch string }. Each failed the original scanner but passed current main. This was found while independently reviewing service-go #128's full scanner-pin upgrade.Extend the existing matcher for explicit Go
var/constdeclarations and named inline struct fields. Punctuation alone is not a declaration boundary: comments containing semicolons or braces remain allowed. Keep innocent prose and released-contract field reads allowed. This is a fix at the shared ownership scanner, not a consumer bypass or second parser.docs/manifest-guard.mddescribes the retained coverage.Maintained regressions check both branch and revision for variables, constants and inline fields. The complete scanner suite passes, including checksum metadata, real generated clients, all prior forbidden categories, allowed prose/contract reads and rejected runtime exclusions. Full conformance/evidence/workflow self-tests are also run. The first F3 follow-up identified punctuated-prose false positives; those were corrected and maintained as negative regressions. Fresh independent F3/F4 closure review at 3a1e906 verified 69 actual scanner runs, retained all named positives/negatives and found no remaining scoped blocker. Hosted scan-test passed in run 40576271810.
This follows merged #11 and closes the earlier matcher regression before codefly-dev/service-go#128 adopts the full owner pin. No issue/ticket was created.