Repository navigation
chore(contract): sync flipcash2 protos to 9d44350 (0.18.0) - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs flipcash2 protos from
3bb442d3to9d44350b(flipcash2-protobuf-api #135, #136, #137, #138) and adds the 0.18.0 changelog entry. Onlychat.v1moved;blob.v1changed only in comments.Renumbered:
EditChatResponse.ResultgetsCOVER_PICTURE_BLOB_NOT_ACCEPTEDinserted at 5, which movesDESCRIPTION_MODERATEDfrom 5 to 6. 0.17.0 shippedDESCRIPTION_MODERATED = 5, so 0.17.0 clients misread a cover-picture rejection and don't recognize 6. This is adopted as merged upstream.StartChatResponse.Resultappends its new case at 7.Renamed (same field numbers, source-breaking): the group
picturebecomesprofile_pictureonMetadata, both group-chat parameter messages andEditChatRequest(Picture→ProfilePicture), along withMetadataUpdate.PictureChanged→ProfilePictureChangedandPICTURE_BLOB_NOT_ACCEPTED→PROFILE_PICTURE_BLOB_NOT_ACCEPTED.Added:
Metadata.cover_picture(= 17, may be unset on feed RPCs),cover_pictureon both group-chat parameter messages andEditChatRequest,MetadataUpdate.CoverPictureChanged(= 7),COVER_PICTURE_BLOB_NOT_ACCEPTED.RosterUpdate.MembershipChanged(= 3): applyroster_summaryby version, keep the cached member list.Chat.SampleChattersandSampledChatter.Chat.SetFeaturedGroupsandChat.GetFeaturedGroups.Changed behavior:
GetRosteris members-only now. A non-member a group's listener rules admit getsDENIED.7765668also regeneratesContractInfo.swiftfor the new changelog heading (0.18.0-dev).App adoption PRs, drafts carrying the scaffolding only, with the pin bump to follow the release:
Both build against this checkout through the local overrides. After merge, run
publish.ymlat0.18.0, then bump the pin on each app PR.