Repository navigation
feat(chat): adopt flipcash2 0.18.0 (cover pictures, featured groups, chatter sampling) - #1686
Merged
Merged
Conversation
…r sampling contract Rename the picture fields to profile_picture and carry cover_picture into ChatMetadata, the metadata entity (Room 43 -> 44) and the DAO, where a feed upsert without a cover keeps the cached one. Map the renumbered EditChat result, the new StartChat cover case, CoverPictureChanged and RosterUpdate.MembershipChanged (applied by version without touching the member list). Add service, repository and controller wrappers with domain and error types for SampleChatters, SetFeaturedGroups and GetFeaturedGroups.
github-actions
Bot
added
type: feature
bmc08gt
force-pushed
the
chore/flipcash2-0.18.0
branch
from
October 6, 2026 16:59
5662d8f to
cf631a2
Compare
bmc08gt
marked this pull request as ready for review
October 6, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts flipcash2-client-protocol 0.18.0 (flipcash2-protobuf-api #135–#138).
Pins
flipcash2-client-protocol0.18.0 ingradle/libs.versions.toml, released from code-payments/flipcash2-client-protocol#25. The pin bump is its own commit.picturetoprofile_pictureacross StartChat, EditChat, the metadata mapping andProfilePictureChanged.cover_pictureintoChatMetadataandchat_metadata.cover_picture_json(Room 43 → 44, auto-migration). The upsert usesCOALESCE, so a feed result that omits the cover keeps the cached one.CoverPictureChangedwrites it unconditionally.COVER_PICTURE_BLOB_NOT_ACCEPTEDfor StartChat and EditChat to newCoverPictureBlobNotAcceptederrors. Results are mapped by enum name, so theEditChatResponse.Resultrenumbering (DESCRIPTION_MODERATED5 → 6) needs no other change here.RosterUpdate.MembershipChanged:RosterStateHolderapplies the summary by version without refetching and leaves the member list alone.sampleChatters,setFeaturedGroupsandgetFeaturedGroupsthrough ChatApi → ChatService → repository →ChatController, with domain and error types. No UI yet.GetRosteris members-only now, butChatController.getRosterhas no callers inapps/, so nothing changes for preview or lobby views.