Repository navigation
feat(routing): open the profile until a DM exists - #989
Merged
Merged
Conversation
This was referenced Oct 6, 2026
bmc08gt
force-pushed
the
feat/profile-refresh-edit-profile-v2
branch
from
October 6, 2026 20:12
780c4d0 to
b52d8a0
Compare
A scan always opens the person's profile after the card's 750ms hold. A username search and a transaction's details open the DM when it exists and the profile until then, through DMRoute. The profile is where the paid chat starts, so nothing routes into a conversation by user ID any more, and tipConversationForUser and tipConversationForUserSendingCash are removed.
Every route to a person now lands on their profile until a DM exists, and the profile owns the paid start-chatting flow. ConversationScreen only opens an existing chat, so the tipDM context, the chatExists/startChattingFee plumbing, the full-width Start Chatting bar, and the open-time Send Cash are unreachable.
Scanning opens the profile now, so the old wait for the empty chat's send-cash button timed out with the profile on screen.
bmc08gt
changed the base branch from
feat/profile-refresh-edit-profile-v2
to
main
October 6, 2026 20:13
bmc08gt
force-pushed
the
feat/profile-refresh-routing
branch
from
October 6, 2026 20:13
9d6275e to
f5eac5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #988.
Every way of reaching a person now opens their profile until you have a DM with them:
The decision lives in
DMRoute.destination(for:dmID:origin:). With nothing routing by user ID any more, this PR deletestipConversationForUserandtipConversationForUserSendingCashrather than adding the redirect view the plan described.ConversationScreenloses the paid-DM gate: no pre-chat.tipDMcontext, no "Send $X to Start Chatting" bar, noSendCashMorphButton. Paying to start a chat happens on the profile now.isTipDmon the bottom bar only fed that button's title, so it went too.TipsSmokeTestsnow expects the tip link to land on the profile's pinned button rather than the empty chat's send button.