Repository navigation
feat(settings): Settings screen behind a gear on the You tab - #985
Merged
Merged
Conversation
This was referenced Oct 6, 2026
The You tab becomes the profile in later slices, so the rows it held move to a Settings screen reached from a gear on the tab: an interim Profile section (the My Account editors until Edit Profile exists), Security, Privacy, Advanced, and Account with a new Account Info screen (phone, email, user ID, authority public key), then the version footer. SettingsMyAccountScreen and SettingsAdvancedFeaturesScreen are removed, and the UI smoke tests now reach Settings through the gear. Base: origin/main 410bb5f.
…nfoDetails.Row The UI tests' failure messages and doc comments still named My Account, which this branch removed. Also rewraps a YouScreen doc comment that was reflowed onto one 110-column line.
bmc08gt
force-pushed
the
feat/profile-refresh-settings
branch
from
October 6, 2026 19:48
3186981 to
25b8be7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of six stacked PRs for the profile refresh (#985 → #986 → #987 → #988 → #989 → #990). Each is based on the previous branch, so review them in order.
The You tab becomes your profile in the next PRs, so the rows it held move to a Settings screen behind a gear on the tab: Profile, Security, Privacy, Advanced, and Account. Account has a new Account Info screen (phone, email, user ID, authority public key), log out, delete account, and the version footer with its beta easter egg.
SettingsMyAccountScreenandSettingsAdvancedFeaturesScreenare gone, and the UI smoke tests reach Settings through the gear.The Profile section is temporary. #988 moves its rows out and deletes it. Two later Settings tweaks also land there rather than here, uppercase section headings and Account Info shown only with beta access, so this branch didn't need rewriting under the four above it.