Skip to content

fix(tests): stop the TipFloor regression shadowing its helper #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Oct 1, 2026
Merged

fix(tests): stop the TipFloor regression shadowing its helper #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions FlipcashTests/Regressions/Regression_6a677815fdca5cb0d6a9ef7e.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,29 +29,29 @@ struct Regression_6a67781 {
[.usd: usdRate, .inr: inrRate, .ngn: ngnRate]
}

private func floor(for fee: FiatAmount) -> TipFloor? {
private func statedFloor(for fee: FiatAmount) -> TipFloor? {
TipFloor.toOpenDM(recipientFee: fee, presets: nil, in: .usd, rates: rates)
}

@Test("A 600 INR fee is stated as $6.26, which covers it, not $6.25")
func inrFee_floorCoversFee() throws {
let floor = try #require(floor(for: FiatAmount(value: 600, currency: .inr)))
let floor = try #require(statedFloor(for: FiatAmount(value: 600, currency: .inr)))

#expect(floor.displayed == .usd(Decimal(string: "6.26")!))
#expect(floor.displayed.converting(to: inrRate).value >= 600)
}

@Test("The $6.25 the sheet used to submit no longer clears the floor locally")
func inrFee_roundedDownEntryIsRejected() throws {
let floor = try #require(floor(for: FiatAmount(value: 600, currency: .inr)))
let floor = try #require(statedFloor(for: FiatAmount(value: 600, currency: .inr)))
let entered = ExchangedFiat(nativeAmount: .usd(Decimal(string: "6.25")!), rate: usdRate)

#expect(!floor.isMet(by: entered))
}

@Test("A 1500 NGN fee is stated as $1.14, which covers it, not $1.13")
func ngnFee_floorCoversFee() throws {
let floor = try #require(floor(for: FiatAmount(value: 1500, currency: .ngn)))
let floor = try #require(statedFloor(for: FiatAmount(value: 1500, currency: .ngn)))

#expect(floor.displayed == .usd(Decimal(string: "1.14")!))
#expect(floor.displayed.converting(to: ngnRate).value >= 1500)
Expand Down
Loading